From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 71A70B389 for ; Tue, 2 Sep 2014 11:27:29 +0200 (CEST) Received: by mail-we0-f174.google.com with SMTP id u57so6606701wes.5 for ; Tue, 02 Sep 2014 02:32:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VvlKEq4Wxfqt5zTFE1qx05O4+zOJ3a7pC4sAmz/pL1Q=; b=BBJVdjSvU449YFebr6ThE4Edl7QNamYCqGCgDosmbbzUviFzjUVqXjsaLB9AoMwnw7 2fknMrGMe7nFlhpjfn62DifPzxr4ryVFTxG/3dC1huvby8xo/gJoeBNdlSYbZ8PiAgzM 3yofP/+MUa2RYXs2kEc5AP5c3Qi93VfxSOJDet3uDkEkIH5u8fpxlj3kCoRXhn1m4vEl wnC4oAcFl6TuqtQZ/hSaRYtajSfFbSonY+doIcyMQKqJf62tsSVxV1qwxTJlrctVi6e8 7jw4mibdKNz7JDN9ppvi6PMN2zMNt875wQuND4vlEn3h+I8uxInu5KoB6otEDt2WKo9Q DojA== X-Gm-Message-State: ALoCoQkJXf2CsLt8PNaDEgXPyoBoZYcfBM4TptcCQqjrr3vsSJtKqkcNFL42c4R4gM2gQrNj5Qwo X-Received: by 10.180.101.129 with SMTP id fg1mr26937436wib.20.1409650320386; Tue, 02 Sep 2014 02:32:00 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id z5sm32475087wib.20.2014.09.02.02.31.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Sep 2014 02:31:59 -0700 (PDT) From: Thomas Monjalon To: "Doherty, Declan" Date: Tue, 02 Sep 2014 11:31:52 +0200 Message-ID: <2319059.S7dZfdPe5P@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com> References: <1408456313-28812-1-git-send-email-declan.doherty@intel.com> <1409560289-29558-5-git-send-email-declan.doherty@intel.com> <345C63BAECC1AD42A2EC8C63AFFC3ADC2737656B@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 09:27:29 -0000 Hi Declan, 2014-09-02 09:22, Doherty, Declan: > I've just noticed that I inserted an extra character into the patch when I was annotating this > patch which will cause this a fail compilation. > > > + TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE -s > > + TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT); > > should have been > > + TEST_BCAST_SLAVE_TX_FAIL_BURST_SIZE - > > + TEST_BCAST_SLAVE_TX_FAIL_MIN_PACKETS_COUNT); > > Thomas, do you want me to submit a V3 of this? I'd prefer to have some comments first. Anyone to review this patchset? -- Thomas