From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D393A0550; Wed, 10 Feb 2021 21:46:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BD451606BC; Wed, 10 Feb 2021 21:46:30 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id E01CB1606BC; Wed, 10 Feb 2021 21:46:29 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 2AB6E580263; Wed, 10 Feb 2021 15:46:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 10 Feb 2021 15:46:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Rx2tya2z8/8nPM7JmGewywxW3TkDHFZetDUxO8RXcuc=; b=v+q3cg3mVovEjS5C 49z/Z5i5k6sd4bVINChvKAjB/E073K5S2TNhqRQg+IivujiB95g5N7iGW2yJQa/K MArVXjlaAqF8eC/Ak8vRzemqzksvSWiw1GjgE91ByBqsAD/voPcqqrgkURcJNX4J LzhLmt3FoQBJuCWJ/GWPRLb0YRd/QgKzugJKGVURskRe0j81uFF3RykZ+FBfNpsV T3lNf9f3pq5snK/YXdbolixh4KYdDCMyKtoKAHoc4Ao2nWGGJNnRYwznBjfSL4YC 4Kwyqf1oO8cm4376cso8xCCoQRPZDw43gitDzmDBfQLp8ek6AB9+WDNFbBPjosSG v8+7bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Rx2tya2z8/8nPM7JmGewywxW3TkDHFZetDUxO8RXc uc=; b=Jvo37yP1ifwaMYAzmFWQavsfpesFI7dD22/Bao6FGypxYIMRuN26lKIYA 5oxJIS2TYO5kwiKiwqZnjlmvxkrlYZSDe5XyXR6+Pu8GKhItwDrOMSnO7AjIggF0 tHfxKvFe6+8qJPPlHDF2klqzSli5YXQwDAtW5HmRVt3rWPZclKJyE/vFe7+SlhF6 TKxXs6x0iDM8MHZcATjxEXzM4iiDGERXCyfF0/eWnDkvYUUTgXdikS+ZS1Mq8pXG wjo0ykat0CkObzBvGEVlPsWoJqU8e6HSsBr0/IkUKDD7BJncmaZeTJm0rv2J+uBC CU78DxB82VGxkqDudAQdaZUTXSGyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheejgddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 330C424005C; Wed, 10 Feb 2021 15:46:26 -0500 (EST) From: Thomas Monjalon To: Feifei Wang Cc: Jerin Jacob , Ruifeng Wang , Jeff Guo , Haiyue Wang , dev@dpdk.org, nd@arm.com, stable@dpdk.org, Paolo Valerio , david.marchand@redhat.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com Date: Wed, 10 Feb 2021 21:46:24 +0100 Message-ID: <2321995.G3BrELjmaN@thomas> In-Reply-To: <20210208090704.1856110-1-feifei.wang2@arm.com> References: <20210208090704.1856110-1-feifei.wang2@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: fix UDP zero checksum error for Arm NEON path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/02/2021 10:07, Feifei Wang: > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > To fix it for the NEON path in Arm platform, change the bad UDP checksum to > unknown, and then let software application to recompute the checksum. > > This patch depends on: > http://patches.dpdk.org/patch/87750/ > > NICs: 82599(igb) > Driver: ixgbe(vector) > Architecture: arm64 > $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i > --port-topology=chained --enable-rx-cksum > test-pmd> set fwd rxonly > test-pmd> set verbose 1 > test-pmd> start > > 1. UDP Test: > Package: (Ether()/IP()/UDP(checksum=0) > ol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_GOOD > > 2. TCP Test: > Package: (Ether()/IP()/TCP(checksum=0) > ol_flags: PKT_RX_L4_CKSUM_BAD PKT_RX_IP_CKSUM_GOOD > > Bugzilla ID: 629 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Reported-by: Paolo Valerio > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang I wonder why the patch for SSE Rx is applied in next-net-intel while this one for NEON Rx is ignored. Either I merge both or none. I'll go with both. Applied, thanks.