From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 4EFCD4CE4
 for <dev@dpdk.org>; Fri,  2 Sep 2016 14:57:32 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id v143so10818294wmv.0
 for <dev@dpdk.org>; Fri, 02 Sep 2016 05:57:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=icW56oWadq5BGgc6/S8fMWhWivSuCxKfXjt1+pyJasE=;
 b=nzH/0fNtNF4NiXiqRBDyvLCKTYIGlm7R8w09jjuyblT5uuo/Mwb8RoSPjJsdPcGoM+
 V7c3A+1HsRcZFSfM7EZJsItpg/41MK11J/Ga5ZzNsNd7b4K5n7uScwcdRkcd5DbuGssl
 nxAaAFs7O2zwXktmJWKEbghGQdWZR1zFci/JO0tzshXt+fbZaVdaOZGBoOgRUz62C90K
 ry4EuNdW3bQAbR7iSmF5eulMqx856HpMf9YZBDmDoeFegZ+i+GxBtocv2MEkm2rh+liq
 KPy5CF+rZgDiK0wpIhmVZXfzOan1869gxr1ZlV0afcOhC+nGqAXJbkPus+V9kZ9lB+xg
 uiPw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=icW56oWadq5BGgc6/S8fMWhWivSuCxKfXjt1+pyJasE=;
 b=ZyipX1WucifctJWKnBtjUbmvPCEugY7QYczsmH3lzhbdn3jc9kp0CoWl8/VInhvvHi
 El3Pd4KmRhAFInKSoow6XXXYZVtXJ4cg5+WH75+vR4CbRpLM5ZNukEFRC8gDlk26Y4Ah
 zuAZO4JQtuDb9CnaBTGHwGkASJWNHWsLrkCaowHWx4SEqn7Lo6UYhitFd1a/MAN0KcZm
 RsNRpkDH2jYPu1RaX1TIrtghf4SUfickfNdoTySYQ3aAmqQN2HgqXKP5py8+uX4Q0cFU
 +tBUX0ZXTuAoT9+hzrNHYSFKbW9mzFP0palqJSEs1DAFeUv0iCWjZhBB8nNijy1NZjPc
 UwUw==
X-Gm-Message-State: AE9vXwN2jzPMNj9Co3WWPeY3g7DfvqPeihpwjjcRyFG4PM+yNA9ZP5HH5eRnHRZ3mF30Ja1r
X-Received: by 10.28.150.10 with SMTP id y10mr3000042wmd.112.1472821052066;
 Fri, 02 Sep 2016 05:57:32 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id 142sm3501005wmh.12.2016.09.02.05.57.31
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 02 Sep 2016 05:57:31 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jason Wang <jasowang@redhat.com>
Cc: dev@dpdk.org, huawei.xie@intel.com, yuanhan.liu@linux.intel.com,
 mst@redhat.com
Date: Fri, 02 Sep 2016 14:57:30 +0200
Message-ID: <2323448.KHrCRZ2JeF@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1472798220-7121-1-git-send-email-jasowang@redhat.com>
References: <1472798220-7121-1-git-send-email-jasowang@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: support modern device id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Sep 2016 12:57:32 -0000

2016-09-02 14:36, Jason Wang:
> Spec said "The PCI Device ID is calculated by adding 0x1040 to the
> Virtio Device ID". So this patch makes pmd can recognize modern virtio
> net id.

Please could you describe what is a modern virtio-net?

>  #define VIRTIO_PCI_DEVICEID_MIN 0x1000
>  #define VIRTIO_PCI_DEVICEID_MAX 0x103F
> +#define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041

It doesn't match the sentence above: 1000 + 1040 = 2040

By the way, VIRTIO_PCI_DEVICEID_MAX is not used in the code.