From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70788A04B5; Fri, 30 Oct 2020 11:43:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B257AC7F4; Fri, 30 Oct 2020 11:43:56 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 7531FC7F0 for ; Fri, 30 Oct 2020 11:43:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 10AFC5804B3; Fri, 30 Oct 2020 06:43:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 30 Oct 2020 06:43:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ctmaXqVjYcYNDyyf5P6rnOyZ2UnWDPe57n3i4naR6a4=; b=raLN/QK5Bezpyppf QgCB+4mXEZgbH65nyH9iBfW4H5VrOQmURcWBr58sO6LsFrStbJqv1RVow6PL0Syf alIVpDicBkjuH5IUuv6KxScOvJ+8f6m1uc8N0S7TJZMFmd90afVlu/lK8aCLxtcW tBluDZOqdwE3SLzmVDN+zX+dIHCuw8ype0ZGn/G+8IrTLbd5oN1Y2MIzipUDmGMD Dot6Kc3sdrOWY2nt8k3sU1wb/0jodGkpmRZzzyT4s0zsexyE6U8EEdgUdL4VibBT YHY+Q2TefwhGM+LMfIfiC+i3D4Fz5kue5/AYz3XVd410lnJbFVZNiaWSlCB6JQ/x XfPU6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ctmaXqVjYcYNDyyf5P6rnOyZ2UnWDPe57n3i4naR6 a4=; b=ORMXSOXjXkaKpeqrtlN4c9r6zwO7/VR7U2NajEgybYrdNjshJcJaTnd8i q4+Vo2Mwha1L2UoHkH8D4l/R8tJA/UH1qc+8AO553rcLSPMsEzwmvgplrYHc/+Qn 5q/g1W96+oKUtBLzsL+dE3HlFE947JfcKF7T1SwifZ7xoDC/95Lps7LQEZsFQ6XB zIci6C1eGFOf8gu9pCUEBUmFX6S1eC2cyEhrN7q5bPqi/L9Z9WEC7rCg4S1/Uoq/ MVTRTCKxcSV4cI1drMt4s4/2WblvGka6nmtETs1N0qci3Q1ITMdIVBtIs3+x9XXO g0ympSetisGYob3KAToE4llL+hJgA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleehgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C0FD3280060; Fri, 30 Oct 2020 06:43:50 -0400 (EDT) From: Thomas Monjalon To: "McDaniel, Timothy" , Liang Ma , Anatoly Burakov , Jerin Jacob Cc: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "jerinj@marvell.com" , "david.marchand@redhat.com" , liang.j.ma@intel.com, anatoly.burakov@intel.com, john.mcnamara@intel.com, david.hunt@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ruifeng.wang@arm.com, anatoly.burakov@intel.com, David Christensen Date: Fri, 30 Oct 2020 11:43:49 +0100 Message-ID: <2325850.Nujp9jq6r4@thomas> In-Reply-To: References: <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 00/23] Add DLB2 PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/10/2020 11:32, Jerin Jacob: > McDaniel, Timothy wrote: > > From: Thomas Monjalon > > > 30/10/2020 10:43, Timothy McDaniel: > > > > - note that the code still uses its private byte-encoded versions of > > > > umonitor/umwait, rather than the new functions in the power > > > > patch that are built on top of those intrinsics. This is intentional. > > > > > > Why? Now these intrinsics are available in the main branch. > > > We should avoid duplicating such code. > > > > I had asked that the low level intrinsics (UMWAIT/UMONITOR) > > be split out so that DLB/DLB2 could use them instead > > of its own private byte-encoded versions, > > but instead we have these wrappers that call the low level > > intrinsics. Those wrappers introduce additional overhead > > that is not required for DLB/DLB2. > > I have a meeting with Ma Liang on Monday to discuss. Why did not you tell it on the mailing list? It would have prevented from merging a wrong/useless API. I am now convinced that the hard push to get those intrinsics which started with a lack of communication (no roadmap, no Cc, no reply) is really a bad story in the community process. > Then why we merged the EAL patches? The all-purpose was to use this by > other subsystems. If it is only for the power library then we should > make specific to the power library. I agree with you Jerin. > Thomas, Should I take this series in eventdev > or I need to wait to sort out this? I think you could merge those patches and I revert the EAL ones. In any case, I won't merge any more patch about power monitor in this release. I don't like swimming in the fog.