From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5B46A0C4E; Mon, 8 Nov 2021 20:47:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DC8040151; Mon, 8 Nov 2021 20:47:58 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id E1CE940040 for ; Mon, 8 Nov 2021 20:47:57 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6575B5C004E; Mon, 8 Nov 2021 14:47:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 08 Nov 2021 14:47:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= nUThs5ed8OMzn8Gi1LYcStDvxv5pEbCowWI672rpobQ=; b=TuI49R16ixxL/MRn nGMNlL5jLloDERZIJQShVetK8i0d4IUgUEfBcz4A+cuZx4MSlMnEUQPJyRHLP0P5 wLhmi1XWA23k1yvoucycJn7lH02mV8Ou+HhtkoiUiJyv3C4NMtN+BxowDvg0b6LA rByZ1JZ4LKvFMCgm30Rwqoj8wzaE25Ht0z/wMKqb7CvA9ucKwI5YuTL2ITd19PDu 87W8Cgq3Y16dvOxtOyjZH9WF4a+aN4C1WN7AsUrtVYU1pbfUwqWqAcd+N+194lHc 6MWsu2NRJyUW1yQ/b9lNJSaVQkJ8b9GUx2mwmMpCXqoiFfMuFyxKLWbdnhf82PWh WdJNLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nUThs5ed8OMzn8Gi1LYcStDvxv5pEbCowWI672rpo bQ=; b=arkTBZtosjhPk6dIuS/34VDu17oJFcKxhroY9Q/e602HacIhgYuITkR8C kQpD9iZwph/fp5SdiqnxfbQdYMq2pzXKK5h/BxoSPFalW0f/lA5B6E6xnZeAOBUd 251fTpsRXUB1FPAdrsyP9McvWzKkmGbsAfXKOWgXRepHWetbu2A+g96lXFEgDV2V zlfu8MSoV8d0c/8b2F5vUSWBx05fXHzT1DevquXjlq+D8XKJVx5i/FPPQo7CwOpX z4b9/BsqGLWCkWhGkYBvBBp3WSJIyygRrKdfhdL+BqtOo1YWg+WcqorzK2r+N7nM dUCaTQJv2t0CcjQulNVuKtSl2lBnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddvgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 8 Nov 2021 14:47:56 -0500 (EST) From: Thomas Monjalon To: "Xu, Ting" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Yang, Qiming" , "Guo, Junfeng" , "orika@nvidia.com" , "viacheslavo@nvidia.com" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" Date: Mon, 08 Nov 2021 20:47:54 +0100 Message-ID: <2326436.Zqoc9nv7S9@thomas> In-Reply-To: <212e24c9848f4fd382f032d3558c099e@intel.com> References: <20211008070934.6956-1-ting.xu@intel.com> <212e24c9848f4fd382f032d3558c099e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/2] enable protocol agnostic flow offloading in RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2021 03:44, Zhang, Qi Z: > From: Xu, Ting > > From: Thomas Monjalon > > > 05/11/2021 14:18, Xu, Ting: > > > > From: Thomas Monjalon > > > > > 04/11/2021 03:22, Ting Xu: > > > > > > Enable protocol agnostic flow offloading to support raw pattern > > > > > > input for RSS hash flow rule creation. It is based on Parser > > > > > > Library > > > feature. > > > > > > Current rte_flow raw API is utilized. > > > > > > > > > > I remember raw item was especially targetting encapsulation action. > > > > > Which action do you achieve in ice PMD? Only RSS with raw item? > > > > > > > > > > For matching, raw item is quite limited. I think the new flex item > > > > > is more appropriate for general custom protocol parsing. > > > > > Did you look into flex item feature? > > > > > > > > > Hi, Thomas, we make use of the API for rte_raw to achieve our > > > > protocol agnostic flow offloading method, including RSS and FDIR. > > > > Behind it is the new Parser Library feature based on DDP, > > > > > > Where is this parser library code? > > > > Parser Library is committed before as ice base code. > > > > > > > > > rather than the original logic I think. > > > > > > > Binary-format pattern spec and mask are passed to Parser Library and > > > > the corresponding protocol ID and offset will be provided. > > > > > > Sorry you didn't reply about the new flex item added in this release. > > > Do you know it was added? > > > https://git.dpdk.org/dpdk/commit/?id=dc4d860e8a89 > > > > > > > Protocol agnostic flow offloading is based on ice DDP feature, although > > they all want to make flow creation more flexible, I think it is different > > with flex item. > > @Zhang, Qi Z Hi, Qi, are you familiar with flex item? > > > > Yes, this is a very Intel DDP specific feature, the goal is to make our driver to support any customized parser (DDP) without change code. > > Below steps are planned: > > 1. raw packet interface, this help on quick POC, as its simply the rte_flow parser, but of cause it's not scale for an DPDK application to support different vendor. > 2. enable a build-in util to forge a packet from a sequence of rte_flow headers, then the application will be scale, but the missing part is how to describe a customized header, we have similar idea like json, but seems "Flex Item" already help to fix this gap, and we will improve the solution base on it. Yes please, I hope flex item will fit with your need.