* [dpdk-dev] [PATCH v1] eventdev: fix build error
@ 2018-10-09 10:13 Ferruh Yigit
2018-10-10 19:43 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2018-10-09 10:13 UTC (permalink / raw)
To: Nikhil Rao, Jerin Jacob; +Cc: dev, Ferruh Yigit, stable
build error:
.../lib/librte_eventdev/rte_event_eth_tx_adapter.c:
In function ‘txa_service_queue_del’:
.../lib/librte_eventdev/rte_event_eth_tx_adapter.c:800:7:
error: ‘ret’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
compilation terminated due to -Wfatal-errors.
https://mails.dpdk.org/archives/test-report/2018-October/065919.html
'ret' may be used uninitialized when 'dev->data->nb_tx_queues' is 0,
although this is not a practical value, initialize 'ret' to cover this
case.
Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
index aae0378d5..3a21defba 100644
--- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c
@@ -797,7 +797,7 @@ txa_service_queue_del(uint8_t id,
if (tx_queue_id == -1) {
uint16_t i;
- int ret;
+ int ret = -1;
for (i = 0; i < dev->data->nb_tx_queues; i++) {
ret = txa_service_queue_del(id, dev, i);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH v1] eventdev: fix build error
2018-10-09 10:13 [dpdk-dev] [PATCH v1] eventdev: fix build error Ferruh Yigit
@ 2018-10-10 19:43 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-10-10 19:43 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Nikhil Rao, Jerin Jacob, stable
09/10/2018 12:13, Ferruh Yigit:
> build error:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:
> In function ‘txa_service_queue_del’:
> .../lib/librte_eventdev/rte_event_eth_tx_adapter.c:800:7:
> error: ‘ret’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> compilation terminated due to -Wfatal-errors.
>
> https://mails.dpdk.org/archives/test-report/2018-October/065919.html
>
> 'ret' may be used uninitialized when 'dev->data->nb_tx_queues' is 0,
> although this is not a practical value, initialize 'ret' to cover this
> case.
>
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
The root cause is a new feature in 18.11, so no need to Cc stable.
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied (without stable backport tag), thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-10 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 10:13 [dpdk-dev] [PATCH v1] eventdev: fix build error Ferruh Yigit
2018-10-10 19:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).