From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 580CE2965 for ; Tue, 8 Mar 2016 11:32:11 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n186so124642652wmn.1 for ; Tue, 08 Mar 2016 02:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BNTIX3ww5xWvvAz1qXCHxQNdq+xE48SrjULPuCTaFEY=; b=yO+AkNrSa1KAJwkwlw1qULvSDMIfgwtDMyor5D1Rx6ms5tKf3a2iAB7Cu1w55r3wvi o9fQg89tkwNPZllgSihFPNTeoHgB61F7nwNUmnqnS2KIDOpg4mnv0fUO8lQKBwAuAPog NIAGTjeA+CvgM45t7+Bu77tuCWtpTkMRD4GneT2DsMNgUUl/3F0aN78q47GFHISoxJOx c59EbpJrgE7wFMpooHWyN9dfTJN+nq/Yb8dgnYA519EmewaAvccQ7CtYORyXq8ve02ov DTTB25mYu5yeZidpexARd41QiGv22qyNIfqerbhiQdBF62V5ZAxF9/Lg6eaZ4Hz1PtnH aAKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=BNTIX3ww5xWvvAz1qXCHxQNdq+xE48SrjULPuCTaFEY=; b=dPMJYOrH+uHZ4lodOmgP3ui0VhdZqycCYtwmzrc6t2EJ3dvwE1dvRRNOELdSxko3n5 X+7mAz5sV2K+wC3PV+eJbPj5ufN3peubfYa4BhFqUeFLzQR0U/t1Qr5YxGtDrBF+O13j O0OaTkD9TpOztwpS7K+x/UXjtMG7Vg8DzGwphW3phCcmlQ75xQOf1tmxf/2vuDGQERl3 WYnWI+LOkJhFRu2EzXGI58TiuPCi3YSA8r9K6jFZGrMXLShO/nKAP9ti63lCdqqFCudM Y7vGxWs1C3QMGINhcu8WAvJu/VDDmBWwMR7snT2kyAL07X1+h8bphsJ+pxOMW2abcESB 4EQg== X-Gm-Message-State: AD7BkJJ1WgNp1fasoq8x5DFHOwMEzHItVWnTBUjg+rPoCJSaM97ZExi+NP1fSJB8hQCKsK74 X-Received: by 10.194.63.7 with SMTP id c7mr28187563wjs.168.1457433131002; Tue, 08 Mar 2016 02:32:11 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id hx10sm2242669wjb.25.2016.03.08.02.32.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2016 02:32:10 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 08 Mar 2016 11:30:33 +0100 Message-ID: <2329500.UVQ1bbgajc@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160308090445.GN14300@yliu-dev.sh.intel.com> References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com> <56DE921A.4060203@redhat.com> <20160308090445.GN14300@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: nakajima.yoshihiro@lab.ntt.co.jp, mst@redhat.com, p.fedin@samsung.com, ann.zhuangyanying@huawei.com Subject: Re: [dpdk-dev] [PATCH v2 1/5] mem: add --single-file to create single mem-backed file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 10:32:12 -0000 2016-03-08 17:04, Yuanhan Liu: > On Tue, Mar 08, 2016 at 10:49:30AM +0200, Panu Matilainen wrote: > > On 03/07/2016 03:13 PM, Yuanhan Liu wrote: > > >To me, maybe you could base the SINGLE_FILE_SEGMENTS option, and add > > >another option, say --no-sort (I confess this name sucks, but you get > > >my point). With that, we could make sure to create as least huge page > > >files as possible, to fit your case. > > > > Note that SINGLE_FILE_SEGMENTS is a nasty hack that only the IVSHMEM config > > uses, getting rid of it (by replacing with a runtime switch) would be great. > > Can't agree more. +1 > BTW, FYI, Jianfeng and I had a private talk, and we came to agree that > it might be better to handle it outside the normal huge page init stage, > just like this patch does, but adding the support of multiple huge page > sizes. Let's not add more messy code there. > > --yliu > > > OTOH IVSHMEM itself seems to have fallen out of the fashion since the memnic > > driver is unmaintained and broken since dpdk 2.0... CC'ing the IVSHMEM > > maintainer in case he has thoughts on this. The ivshmem config was not used for memnic which was using ivshmem only for data path. CONFIG_RTE_LIBRTE_IVSHMEM and CONFIG_RTE_EAL_SINGLE_FILE_SEGMENTS are more about full memory sharing. I have the feeling it could be dropped. It there are some users, I'd like to see a justification and a rework to remove these build options.