From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6AB3A0528; Thu, 9 Jul 2020 14:22:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F4981E870; Thu, 9 Jul 2020 14:22:16 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 794B81E86E for <dev@dpdk.org>; Thu, 9 Jul 2020 14:22:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0794A5C0114; Thu, 9 Jul 2020 08:22:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 09 Jul 2020 08:22:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= R5a5w66dDcyjRCH4Esclv3jsRdb0KvgAOGFimFeT5bk=; b=LAmzVBslozVDKUhu XkXg0xVg6Dn0O1dYvYKYO/9Mdt+f14bUv4V8hoMI5gB9qhZHcxVdjsSyacuS+Od1 rFOltO6CwcJeKtUDSLf2a3xuQUsCPvhqBhYO7mAej3VNOhJBwJ4c9gDWd+k4cI7a ci664IdoPCakxrW/esF5BnJ/NiRhzMIEW92D8CCuvLW4em2xzARG6lxhRn/inVa0 N7ZH63JhM4/g19oEY0q+ynOIjHIw5YIadm+gu4ciiDq4emTgsQ0w/ZAADFBwEivG gqjOXgh2wKHlruF1iWPVJTl8Tk8vF5kI0f0yrivK2CP/C9/AFbkqNh6/GmS99nI1 p14yKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=R5a5w66dDcyjRCH4Esclv3jsRdb0KvgAOGFimFeT5 bk=; b=E8sNWrF62n9EIf+VrpWwvq4rWpKHKc1lZmQqxiC61c9q4ue+LiJuU/QWP gkzeln5T97B1KGPMQTVhPIdS1SYXQg+Qa3pp6apzBuDtEZgCWOUYCUTvTjEAYHaZ 1+jYw+d994dL7WPLLtWHGQNH8uuodGaCCWCG5pr75FU0MulfcEN43JzkBxYHEDNC /Ep+OPx5/d+9M2XAc0orMORJV13/3RVqXgyhJMohHUM2y6/3K2ceiY3i4YPoRM8Z PhFqayYTmEIxnUqXFdCRl4AnmP4k0G5hLmHsraSrk2Gt/n4Km0z1ahZtTFUY2+tz AGA1qkh+4W00DY9FOTo84yynOPK7Q== X-ME-Sender: <xms:9gsHXwSFIeqv-NYWVx1ucrHaW02LtumXZIXeNwCx4Bz6n5q4UBb9WQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudelgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:9gsHX9xWbS2a3PgKpna7cBK36JXRzRBcD_79m2yJOXF8v37MnDZGWQ> <xmx:9gsHX937x2WB8xgQyNkBxhzQovcCwkmJd5YcAQ7XrTUwdGXagU1ynw> <xmx:9gsHX0A3Dh3PkiixNn_MdzrmpH-OLU1HafOGq_8VxTyh3gqsz83RdA> <xmx:9gsHX8uSJUWZnaf9opufbsJOcJKtLqy44lj5TOsEdZ_pNXYt4wjqJA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E15053280059; Thu, 9 Jul 2020 08:22:13 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Bing Zhao <bingz@mellanox.com> Cc: orika@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com, matan@mellanox.com, dev@dpdk.org Date: Thu, 09 Jul 2020 14:22:12 +0200 Message-ID: <2329750.AB1Zr4nes2@thomas> In-Reply-To: <1594219387-240274-3-git-send-email-bingz@mellanox.com> References: <1594219387-240274-1-git-send-email-bingz@mellanox.com> <1594219387-240274-3-git-send-email-bingz@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 08/07/2020 16:43, Bing Zhao: > In the translation stage, the eCPRI item should be translated into > the format that lower layer driver could use. All the fields that > need to matched must be in network byte order after translation, as > well as the mask. Since the header in the item belongs to the network > layers stack, and the input parameter of the header is considered to > be in big-endian format already. > > Base on the definition in the PRM, the DW samples will be used for > matching in the FTE/STE. Now, the type field and only the PC ID, RTC > ID, and DLY MSR ID of the payload will be supported. The masks should > be 00 ff 00 00 ff ff(00) 00 00 in the network order. Two DWs are > needed to support such matching. The mask fields could be zeros to > support some wildcard rules. But it makes no sense to support the > rule matching only on the payload but without matching type filed. > > The DW samples should be stored after the flex parser creation for > eCPRI. There is no need to query the sample IDs each time when > creating a flow rule with eCPRI item. It will not introduce > insertion rate degradation significantly. > > Signed-off-by: Bing Zhao <bingz@mellanox.com> > --- > drivers/common/mlx5/mlx5_prm.h | 16 ++++- > drivers/net/mlx5/mlx5.h | 15 +++++ > drivers/net/mlx5/mlx5_flow_dv.c | 130 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 160 insertions(+), 1 deletion(-) In this patch, you could add the feature in the release notes, as part of mlx5 section, and probably in the mlx5 guide too.