From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 877994C74 for ; Thu, 9 May 2019 14:05:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 05:05:20 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.91.208]) ([10.251.91.208]) by fmsmga001.fm.intel.com with ESMTP; 09 May 2019 05:05:18 -0700 To: Thomas Monjalon , Arnon Warshavsky Cc: dev@dpdk.org, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ranjit.menon@intel.com, pallavi.kadam@intel.com References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <2691001.bJ2rVGK9ui@xps> From: "Burakov, Anatoly" Message-ID: <232986ad-cd88-4766-ada2-6ec7272dd62a@intel.com> Date: Thu, 9 May 2019 13:05:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2691001.bJ2rVGK9ui@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 12:05:22 -0000 On 08-May-19 12:15 PM, Thomas Monjalon wrote: > 24/04/2018 08:41, Arnon Warshavsky: >> The purpose of this patch series is to cleanup the library code >> from paths that end up aborting the process, >> and move to checking error values, in order to allow the running process >> perform an orderly teardown or other mitigation of the event. >> >> This patch modifies the majority of rte_panic calls >> under lib and drivers, and replaces them with a log message >> and an error return code according to context, >> that can be propagated up the call stack. >> >> - Focus was given to the dpdk initialization path >> - Some of the panic calls within drivers were left in place where >> the call is from within an interrupt or calls that are >> on the data path,where there is no simple applicative >> route to propagate the error to temination. >> These should be handled by the driver maintainers.. >> - local void functions with no api were changed to retrun a value >> where needed >> - No change took place in example and test files >> - No change took place for debug assertions calling panic > > I did a status of rte_panic/rte_exit calls in libs. > > There are a lot of cleanups to do in EAL. > We may apply the same kind of solution for Linux, FreeBSD and Windows. > > The status is described below in a kind of call tree: > > librte_mempool: > void rte_mempool_* > RTE_LIBRTE_MEMPOOL_DEBUG > rte_panic > (and other similar places) Could an argument not be made that when debugging options are enabled, having rte_panic there is actually useful? -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 76C2AA0096 for ; Thu, 9 May 2019 14:05:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E5A974C8D; Thu, 9 May 2019 14:05:22 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 877994C74 for ; Thu, 9 May 2019 14:05:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 05:05:20 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.91.208]) ([10.251.91.208]) by fmsmga001.fm.intel.com with ESMTP; 09 May 2019 05:05:18 -0700 To: Thomas Monjalon , Arnon Warshavsky Cc: dev@dpdk.org, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ranjit.menon@intel.com, pallavi.kadam@intel.com References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <2691001.bJ2rVGK9ui@xps> From: "Burakov, Anatoly" Message-ID: <232986ad-cd88-4766-ada2-6ec7272dd62a@intel.com> Date: Thu, 9 May 2019 13:05:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2691001.bJ2rVGK9ui@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509120517._U7tgn0xEcE1YYNhjoyDkFEvFWrOE5ri93fjTCbfY-k@z> On 08-May-19 12:15 PM, Thomas Monjalon wrote: > 24/04/2018 08:41, Arnon Warshavsky: >> The purpose of this patch series is to cleanup the library code >> from paths that end up aborting the process, >> and move to checking error values, in order to allow the running process >> perform an orderly teardown or other mitigation of the event. >> >> This patch modifies the majority of rte_panic calls >> under lib and drivers, and replaces them with a log message >> and an error return code according to context, >> that can be propagated up the call stack. >> >> - Focus was given to the dpdk initialization path >> - Some of the panic calls within drivers were left in place where >> the call is from within an interrupt or calls that are >> on the data path,where there is no simple applicative >> route to propagate the error to temination. >> These should be handled by the driver maintainers.. >> - local void functions with no api were changed to retrun a value >> where needed >> - No change took place in example and test files >> - No change took place for debug assertions calling panic > > I did a status of rte_panic/rte_exit calls in libs. > > There are a lot of cleanups to do in EAL. > We may apply the same kind of solution for Linux, FreeBSD and Windows. > > The status is described below in a kind of call tree: > > librte_mempool: > void rte_mempool_* > RTE_LIBRTE_MEMPOOL_DEBUG > rte_panic > (and other similar places) Could an argument not be made that when debugging options are enabled, having rte_panic there is actually useful? -- Thanks, Anatoly