Re: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-10-23 01:22, Lu, Wenzhuo:
> From: Richardson, Bruce
> > >  union rte_eth_fdir_flow {
> > > -	struct rte_eth_l2_flow     l2_flow;
> > > -	struct rte_eth_udpv4_flow  udp4_flow;
> > > -	struct rte_eth_tcpv4_flow  tcp4_flow;
> > > -	struct rte_eth_sctpv4_flow sctp4_flow;
> > > -	struct rte_eth_ipv4_flow   ip4_flow;
> > > -	struct rte_eth_udpv6_flow  udp6_flow;
> > > -	struct rte_eth_tcpv6_flow  tcp6_flow;
> > > -	struct rte_eth_sctpv6_flow sctp6_flow;
> > > -	struct rte_eth_ipv6_flow   ipv6_flow;
> > > +	struct rte_eth_l2_flow         l2_flow;
> > > +	struct rte_eth_udpv4_flow      udp4_flow;
> > > +	struct rte_eth_tcpv4_flow      tcp4_flow;
> > > +	struct rte_eth_sctpv4_flow     sctp4_flow;
> > > +	struct rte_eth_ipv4_flow       ip4_flow;
> > > +	struct rte_eth_udpv6_flow      udp6_flow;
> > > +	struct rte_eth_tcpv6_flow      tcp6_flow;
> > > +	struct rte_eth_sctpv6_flow     sctp6_flow;
> > > +	struct rte_eth_ipv6_flow       ipv6_flow;
> > > +	struct rte_eth_mac_vlan_flow   mac_vlan_flow;
> > > +	struct rte_eth_tunnel_flow     tunnel_flow;
> > 
> > Can you please minimize the whitespace changes here. It looks in the diff
> > like you are replacing the entire set of entries, but on closer inspection it
> > looks like you are just adding in two extra lines.
> Using vi or other editing tools, we can see all this fields are aligned. I think it's
> worth to keep it. 

Bruce means you should avoid changing lines only for alignment.
It's not a big deal if mac_vlan_flow is not perfectly aligned.
When cosmetic rework is really needed, it's better to do it in a separate patch.