From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 1E133C458 for ; Fri, 23 Oct 2015 09:31:00 +0200 (CEST) Received: by wicll6 with SMTP id ll6so19019142wic.0 for ; Fri, 23 Oct 2015 00:31:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+qE5IlXNEjnhiCAgrIiU7fNAhTOoluN0Pzajxq/4oKI=; b=QGL6MG6ehoeJQqU/5wt660LXQRYEMdiq8/Cj7dNJ+JKxlwqB5bsQ87T3+VzLZPb7pR ZCPM7ATOfyhb5aAq3bkb/L9cxUaxqp8sjH+20eK1PBGk6AmbycjV6AWT2OQfXwX3LySq ptfk/P9iCqQm8j0ULw1tDREEtMtWAXV3MR2NbEQkfbFPOWboEIekj4HEkHeq6//wPtv7 Um+8Rt6EjL4arN8RUplMSn/ASAsXymI/NGFGaD5jwP8yow0DOXGy2NdIDFRh0aoZcu9e m9Tus4S1XSGqo1O1bMOZgc6/69jovkcfkxHMUUir0bnYAVNibtZKrfdjDBhQbNmzVb+j aqQg== X-Gm-Message-State: ALoCoQnjbOmhAO0oHiZUHnz/hWUsQyB1ocHr99l20Ar33mqmU19qe5HuRzJ+9ckSxhw0ePfOjUzO X-Received: by 10.180.208.68 with SMTP id mc4mr2920719wic.60.1445585459979; Fri, 23 Oct 2015 00:30:59 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id r6sm8666401wia.0.2015.10.23.00.30.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 00:30:59 -0700 (PDT) From: Thomas Monjalon To: "Lu, Wenzhuo" Date: Fri, 23 Oct 2015 09:29:54 +0200 Message-ID: <2331686.veA1YA3sRZ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com> References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com> <20151022125718.GB20740@bricha3-MOBL3> <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 07:31:00 -0000 2015-10-23 01:22, Lu, Wenzhuo: > From: Richardson, Bruce > > > union rte_eth_fdir_flow { > > > - struct rte_eth_l2_flow l2_flow; > > > - struct rte_eth_udpv4_flow udp4_flow; > > > - struct rte_eth_tcpv4_flow tcp4_flow; > > > - struct rte_eth_sctpv4_flow sctp4_flow; > > > - struct rte_eth_ipv4_flow ip4_flow; > > > - struct rte_eth_udpv6_flow udp6_flow; > > > - struct rte_eth_tcpv6_flow tcp6_flow; > > > - struct rte_eth_sctpv6_flow sctp6_flow; > > > - struct rte_eth_ipv6_flow ipv6_flow; > > > + struct rte_eth_l2_flow l2_flow; > > > + struct rte_eth_udpv4_flow udp4_flow; > > > + struct rte_eth_tcpv4_flow tcp4_flow; > > > + struct rte_eth_sctpv4_flow sctp4_flow; > > > + struct rte_eth_ipv4_flow ip4_flow; > > > + struct rte_eth_udpv6_flow udp6_flow; > > > + struct rte_eth_tcpv6_flow tcp6_flow; > > > + struct rte_eth_sctpv6_flow sctp6_flow; > > > + struct rte_eth_ipv6_flow ipv6_flow; > > > + struct rte_eth_mac_vlan_flow mac_vlan_flow; > > > + struct rte_eth_tunnel_flow tunnel_flow; > > > > Can you please minimize the whitespace changes here. It looks in the diff > > like you are replacing the entire set of entries, but on closer inspection it > > looks like you are just adding in two extra lines. > Using vi or other editing tools, we can see all this fields are aligned. I think it's > worth to keep it. Bruce means you should avoid changing lines only for alignment. It's not a big deal if mac_vlan_flow is not perfectly aligned. When cosmetic rework is really needed, it's better to do it in a separate patch.