From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CEA9A0C45; Thu, 25 Nov 2021 11:51:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D68840DFD; Thu, 25 Nov 2021 11:51:23 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id DE55340DF5 for ; Thu, 25 Nov 2021 11:51:21 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 193D73201D59; Thu, 25 Nov 2021 05:51:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 25 Nov 2021 05:51:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= BPBuS9Tp2uS3oNlG5YsAo2Js+D23IWPL/wl37ux3Q1k=; b=o9fKHuGV0GLeQg4k SP/bke6KGGsa5fB0N+e7kGsQG7qPgFadyztmEYCSxoCiwBCD9c8t7QKStuLYP7wa TxZKOt6s+0Xx0i6dr11eRaARPv53SFUuaa6DVi0ZoRmlLE5kXDyRaDrnE2i/3EJR DEIOkKbLSKzSbeIE3XgKvm06bXtocPj1teTi9WL8m8nv5AGAscPYxW3qYHfYLtEG 7Lx/UGdtbGSPg+zFnCwWdW7dpqClsQ8m08cNl/3BOIDu+HZrdjwxuUCgYPtWNbh+ +P4nWTgju50hU9BOLi1FmX6XKXTtqtz1z1lJkdpaiBNHCRjH3JcmvvMtocTkYckM /RD22w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BPBuS9Tp2uS3oNlG5YsAo2Js+D23IWPL/wl37ux3Q 1k=; b=LNT8E5Qg4vwYrmLz3BOcPgPi6CfgyK4TZNolJJkKj7NceGVx/y5X0h3gm OrWAvMJDKbncQs0oVi9aMvURjDMby0O1UH/9UZ3z3poPdS2jyb/Gw43/OO+j29KI IIgFUKctIN4rqmnsB4v8spQqhyvHYjPMnRtMXLDRhJBe/OmfAUzt9uVqXOHlHu6f wYRngQ/sWDEkkeQQffi23W9zDBKNw8Un2ZSgqeTtLn2LEaEasnv30DrO4hhi3PKU D/MpkfCXpmbsH3fcSsvyzJfSEaYu9Vm0nqoJ2x6RQkq26OvNmelENyN40QqkM5WL B+1w1diAvAFo6T/3pv4JCr3o3qa9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedtgddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Nov 2021 05:51:17 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Andrew Rybchenko , dev@dpdk.org, Jerin Jacob , chenbo.xia@intel.com, fengchengwen@huawei.com, conor.walsh@intel.com, david.marchand@redhat.com Subject: Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok Date: Thu, 25 Nov 2021 11:51:15 +0100 Message-ID: <2331786.SopQPhdIux@thomas> In-Reply-To: References: <20211020134840.2421686-1-bruce.richardson@intel.com> <7da17c30-18a2-4da5-60b3-c03d7a73eeb5@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/10/2021 02:11, Jerin Jacob: > On Wed, Oct 20, 2021 at 7:58 PM Andrew Rybchenko > wrote: > > On 10/20/21 5:26 PM, Bruce Richardson wrote: > > > Since we allow line lengths of up to 100, and the CI checkpatches job > > > only check for that amount, the rest of our tooling and docs should > > > reflect this reality. Therefore we can: > > > > > > * adjust the editorconfig to use that value, to save editors (e.g. vim) > > > from automatically wrapping lines at 80 characters when typing. > > > [Since python checkers all seem to expect 79 character lines max, add > > > for python only a 79-char max line length.] > > > > > > * change the default line length setting in checkpatches script to 100 > > > so as it matches CI and pre-merge checks. > > > > > > * update the docs to clarify that while 80 chars is recommended, up to > > > 100 characters is acceptable. > > > > > > Signed-off-by: Bruce Richardson > > > > Acked-by: Andrew Rybchenko > > Acked-by: Jerin Jacob Acked-by: Chenbo Xia Acked-by: Chengwen Feng Acked-by: Conor Walsh As long as we keep a preference/recommandation for 80 chars, I'm fine. In general I like short lines, but I dislike some "forced" wrapping. So allowing for longer lines and trusting authors to do what fits best is a good call. Acked-by: Thomas Monjalon Applied, thanks.