From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen
Date: Tue, 06 Dec 2016 15:44:12 +0100 [thread overview]
Message-ID: <2333086.mRoocdCpYd@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20266C2B8@IRSMSX103.ger.corp.intel.com>
2016-12-01 13:28, Mcnamara, John:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> > Sent: Thursday, December 1, 2016 11:02 AM
> > To: dev@dpdk.org
> > Cc: Pattan, Reshma <reshma.pattan@intel.com>
> > Subject: [dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen
> >
> > From: Reshma Pattan <reshma.pattan@intel.com>
> >
> > Add pdump library to API doxygen.
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
It triggers a doxygen error:
lib/librte_pdump/rte_pdump.h:204: warning: Found unknown command `\type'
lib/librte_pdump/rte_pdump.h:214: warning: The following parameters of
rte_pdump_set_socket_dir(const char *path, enum rte_pdump_socktype type)
are not documented:
parameter 'type'
Fixed with this change:
- * @type
+ * @param type
Applied, thanks
prev parent reply other threads:[~2016-12-06 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:41 [dpdk-dev] [PATCH] " Reshma Pattan
2016-11-15 16:36 ` Thomas Monjalon
2016-12-01 11:02 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-12-01 13:28 ` Mcnamara, John
2016-12-06 14:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2333086.mRoocdCpYd@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).