From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC2C3A0350; Wed, 1 Jul 2020 16:33:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E9E41C23C; Wed, 1 Jul 2020 16:33:32 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id E36161C22E for ; Wed, 1 Jul 2020 16:33:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 9C3EB9B4; Wed, 1 Jul 2020 10:33:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 01 Jul 2020 10:33:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= kxvblI8JSX0P30eDWH005N6jBv/bxvGZcac5U5Yn7ZY=; b=egUDtoafuQfTFH/O Txa3RE7w0TlLXKBunBPe656IqxcYc7UCm0bTR5CBUGOHfOAkBDBFi1SYdaDq6IDI 8smA31ifNAuOqDUK+MnKV3PqK49ARDHskPLUSz+G4w500yghVCjYaYif8EhNV8oI vBqS63sHYq+HWxn7JwCbbeseaebnfdiKEdNCzHmsk09BwKjSVLqWFIE74aU/MM6i EwmArtlJDgBSetyqg7D+UhjVKKIy7LA6OBoxkrcjMFfpmSPa5iY/8GV9xWKh28Jn jfmMuwdZH0JUVHf4eNv1sTP8SBuKRSdSb7o2Vsl4PV9DVRo5F5vfUdW3WdaTqZgf QhzLRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kxvblI8JSX0P30eDWH005N6jBv/bxvGZcac5U5Yn7 ZY=; b=PmP1p3ywFxwBISYEI0uVLr4/w+9O3MnlMTljoFldKPgRFPv5dRxh4SHFy DRrdZkmxGwBFYVrBNPW1lUcthQzzs3ors71jFNYTz8u2pV64QXNEZdLj6a6zRiJa /T3ycZZuyoI4s986/i7mAI0mVkpOvPvsTavoIH3Q0vT4/Pbp5+zvx7KYux5WJ3ux t/Ylph88gFVMOjG5ZrHTeTIR1qIumgIC0kydxCmex66fJJfKwzQBn458+KbTGiEl 5HecNxbamrMfRdXIxp5C0x6PlTrM0eKdsTkvizeihck6xWp0WGgYst6gUntHOuBN yasXioFgnIxmClLCZDGzlX3gi8jSw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrtddvgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5947B3280059; Wed, 1 Jul 2020 10:33:28 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, ktraynor@redhat.com, bluca@debian.org, sunil.pai.g@intel.com Date: Wed, 01 Jul 2020 16:33:27 +0200 Message-ID: <2333495.2VkqQosWx8@thomas> In-Reply-To: <12416796.FDjNEWGfuk@thomas> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200630141433.818517-7-bruce.richardson@intel.com> <12416796.FDjNEWGfuk@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 6/7] build/pkg-config: improve static linking flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/07/2020 16:30, Thomas Monjalon: > 30/06/2020 16:14, Bruce Richardson: > > Rather than setting -Bstatic in the linker flags when doing a static link, > > and then having to explicitly set -Bdynamic again afterwards, we can update > > the pkg-config file to use -l:libfoo.a syntax to explicitly refer to the > > static library in question. Since this syntax is not supported by meson's > > pkg-config module directly, we can post-process the .pc files instead to > > adjust them. > > > > Once done, we can simplify the examples' makefiles and the docs by removing > > the explicit static flag. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Luca Boccassi > > Acked-by: Sunil Pai G > > --- > > --- a/buildtools/pkg-config/meson.build > > +++ b/buildtools/pkg-config/meson.build > > +# the pkg-config file generated is not best tuned for static linking so > > +# use a script to adjust the linker flags > > +run_command(py3, 'set-static-linker-flags.py', check: true) > > The comment could be made more precise: > # For static linking with dependencies as shared libraries, > # the static libraries must be flagged explicitly. Even better: > # For static linking with dependencies as shared libraries, > # the internal static libraries must be flagged explicitly.