From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5D71F9609 for ; Tue, 7 Jun 2016 11:57:44 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id n184so129002888wmn.1 for ; Tue, 07 Jun 2016 02:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=O9fOzkuK3wI6rCjMj3wuMpj/gVs0ECMBPQ4h44htu74=; b=gPpxhwpkm9lqfAMPMr4iR22V4fwapgoscst65GHuIpPdi4TnJYb6JAY47aJIavxZi7 WT1EveZWwM/uSW/ERqAAPEqOzg/gaoJIVSVEWIXtSBzkVc0saWWe9HhIfoPPN5vJswZO nCDyd0orRqJcGb0g8VSS/4wZzbL6rqHIsFW3twBUoa6f7TjApd/OZC7cOrLf2CZ4Giyn XTxJE4M+RvUNJKX7odrUctynhl/to104bRPGpwGSO5KbhrLUO4E3HZL/UaLK2ncycG7/ thvOD6z2JOF13wAfo583nwazMp6Uq6GIRovMW8eroMFrQDOQYt8dhSbc8GQIHN0XOZ7i zBiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=O9fOzkuK3wI6rCjMj3wuMpj/gVs0ECMBPQ4h44htu74=; b=IacBNQESVyV59jzDg7DBPx7GXouEyXzABBK/CcLkxUteI3I1ibGTBvUkdY/UeWddDa yuh4V/ljA5bYMyiugeL79dCbLG0QqVxOJFuychtMO/ul7a6UHgYkkSRvAp3xpztXSCKj V/aVG732R8rGvONAUdgH1RHP3p9Nt8fA77ckBFE6cUgfVVsB/do8WMxwZLLRy8pFjDuv gSSoXz/SqYZKTjwi38f+WtYUZc5I9xAcbjAcwp+0OlCGS0MWrOnVu2uvGDyCBBFkfAYO 1/roE//W6XZXsseY+JoLph5cqRUmouA47tVdBefWIAB6tIswH6NwnhEHcLQyA0F4Mz5J ikfg== X-Gm-Message-State: ALyK8tK5illVpcdNtiRajoD2J8jY4mSj0KEOa0IXR9mrUVRwwds61bJkaVEJjwYpu0nYJCJO X-Received: by 10.28.7.208 with SMTP id 199mr1775322wmh.74.1465293464171; Tue, 07 Jun 2016 02:57:44 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a140sm18656989wme.18.2016.06.07.02.57.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Jun 2016 02:57:43 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen Date: Tue, 07 Jun 2016 11:57:42 +0200 Message-ID: <2333946.Qkm8bLFkOf@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1464703068-2924-2-git-send-email-nhorman@tuxdriver.com> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1464703068-2924-1-git-send-email-nhorman@tuxdriver.com> <1464703068-2924-2-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv6 1/7] pmdinfogen: Add buildtools and pmdinfogen utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 09:57:44 -0000 2016-05-31 09:57, Neil Horman: > +++ b/buildtools/Makefile > @@ -0,0 +1,36 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > +# All rights reserved. I really think it is a strange copyright for a new empty file. > +#if __x86_64__ || __aarch64__ Better to use CONFIG_RTE_ARCH_64. > +#define TO_NATIVE(x) (x) We already have some functions for endianness in lib/librte_eal/common/include/generic/rte_byteorder.h > +struct elf_info { > + unsigned long size; > + Elf_Ehdr *hdr; > + Elf_Shdr *sechdrs; > + Elf_Sym *symtab_start; > + Elf_Sym *symtab_stop; > + Elf_Section export_sec; > + Elf_Section export_unused_sec; > + Elf_Section export_gpl_sec; > + Elf_Section export_unused_gpl_sec; > + Elf_Section export_gpl_future_sec; > + char *strtab; The export_* fields are not used. > --- /dev/null > +++ b/mk/rte.buildtools.mk I'm sorry I really do not agree it is a good practice to create a new makefile type just for a new directory. My opinion is that you should use and improve rte.hostapp.mk to make it usable for possible other host apps.