From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 686D51B2D7 for ; Mon, 29 Jan 2018 20:50:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E138D21174; Mon, 29 Jan 2018 14:50:25 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 29 Jan 2018 14:50:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=JhCPWtZERm1MASTSH7FJwTnZhn Slb7ZWaM+7iXCv81k=; b=dV+Attdv7XXQzQ+/32sXmGZF7bVifWIbJGNNOYrz3x uYR/aKKfSDfkEE1Vd+/wSK84YRvfCZQ2MD4cd+8wvWHm+7R2NX1RQhu0IElIjGyu nYm5gtqrJDk9bEKk1dpWdVJK0UsraIz5iL7yKmNTu4Fk2Zx/ru95r1QWBQWFoX2G I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=JhCPWt ZERm1MASTSH7FJwTnZhnSlb7ZWaM+7iXCv81k=; b=ZQGpyGE/mhBoqHio/HTYXE J/kKVNHbDCgQNLzucYL1oEEbHGWTW2eN8/cwNYjiuQTxm9+Gbacb4mU62WKro4+o 41v7dnqghjEjWMkrILf4sas1Br714ap+1PErIF0jvaVSbl/758Sh4e/VRf4+4U8x YGsPk9DZ7HoLGm0UTOtfjUkx+aL6hXotQboPLagVO1vcApz0zyexe5JMZ+EU0+6c 5Wi3qLIODX0878OobhX5O+Dkvxchg3Syci3PusVO3EXjBHi/+cv7rXIZNHDXtWYS 5oWx6aGiIBWAHr1vCZZoiK1ntsIK3XJO8egglUdbt+6NmpqqCDb+iWNFIDV8M76g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94A9D24805; Mon, 29 Jan 2018 14:50:25 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Neil Horman Date: Mon, 29 Jan 2018 20:49:39 +0100 Message-ID: <2334903.1Cxcry8nHy@xps> In-Reply-To: <20180125213040.GB12245@neilslaptop.think-freely.org> References: <20180125111225.231897-1-bruce.richardson@intel.com> <20180125213040.GB12245@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pmdinfogen: allow using stdin and stdout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 19:50:26 -0000 25/01/2018 22:30, Neil Horman: > On Thu, Jan 25, 2018 at 11:12:25AM +0000, Bruce Richardson wrote: > > Rather than having to work off files all the time, allow stdin and stdout > > to be used as the source and destination for pmdinfogen. This will allow > > other possible usages from scripts, e.g. taking files from ar archive and > > building a single .pmd.c file from all the .o files in it. > > > > for f in `ar t librte_pmd_xyz.a` ; do > > ar p librte_pmd_xyz.a $f | pmdinfogen - - >> xyz_info.c > > done > > > > Signed-off-by: Bruce Richardson > I think this is a great idea. FWIW, I think the ELF header at the front of the > file should have something that tells you the overall disk file size in it. The > ELF header is pretty easy to parse and do some basic evaluation on, so you could > accelerate that read a bit, by breaking it down into a read of the size of the > header, followed by a parsing of it and a subsequent read of the overall size, > but that probably just nice to have > > Either way, this is a worthwhile feature to have > Acked-by: Neil Horman Applied, thanks