From: Thomas Monjalon <thomas@monjalon.net>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: dev@dpdk.org, "Varghese, Vipin" <vipin.varghese@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] mk: support building with renamed makefile
Date: Wed, 31 Jan 2018 00:43:55 +0100 [thread overview]
Message-ID: <2335057.AkUuH7Y4gb@xps> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D191E4C@BGSMSX101.gar.corp.intel.com>
> > The build system made a recursive call to "make" after creating the build
> > directory. This recursive call used the hard-coded filename "Makefile", which
> > prevented builds from working if the file was renamed and make called using
> > "make -f". Taking the filename from MAKEFILES_LIST make variable fixes this.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
>
> I have validated on Linux environment with custom make file name as 'Makefile.test'.
>
> Acked-by: Vipin Varghese <vipin.varghese@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-01-30 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:59 Marko Kovacevic
2018-01-29 16:14 ` Varghese, Vipin
2018-01-30 23:43 ` Thomas Monjalon [this message]
2018-02-05 9:29 ` Olivier Matz
2018-02-05 9:53 ` [dpdk-dev] [PATCH v2] mk: support renamed Makefile in external project Marko Kovacevic
2018-02-05 10:00 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2335057.AkUuH7Y4gb@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).