From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 794294318A; Tue, 17 Oct 2023 14:08:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3914E4029E; Tue, 17 Oct 2023 14:08:13 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 356B740273 for ; Tue, 17 Oct 2023 14:08:12 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 682CC3200A96; Tue, 17 Oct 2023 08:08:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 17 Oct 2023 08:08:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697544487; x=1697630887; bh=8sob91Grndw5SgCXNGZZPleZIgFfYiHHldC P5e5zIe0=; b=UXZmj+4u8qeRV4xuV8un6QRZ5IRuKH3OggSVTqhGlvwv/VVgeTh zEXfNTRyqxgRklMGKAmPZc3WeFtuGRyVNq/25M67977ZwvUF4d02oxcGnW6G1IdX FvvzK1cxlmwjHX5J9t1LfWbgzeNXkg8SGu6a4QE+8SyI0z+xrjHx9LP8O7fPvZk3 SaBuSGXT4GksH5Q9EFS2lWMoiCdEgQX0DEt+1Ccl12Jw5GRcsvbLEIH7YIBZ8kJZ nJCg8KyPl8JqGVWKhNlvLQeBe1Q1apyDAHs7rdyP3kJxUvCEUWkAQfLwtTRRT3P1 3Z7rEqOS5LEUR11N3pDTLnb1l/PwDyHe67A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697544487; x=1697630887; bh=8sob91Grndw5SgCXNGZZPleZIgFfYiHHldC P5e5zIe0=; b=SEjcf8Qj1crm0xVZmrupgyq7HwUofmvPosdUHiu0yJNV1JndUmP y6CPEwPI+EkmYdeBUyIspvCZiZRoz4poZZRIMaDDEUGnXJZa58ppDIKJJsQvV8gL e6MOSXH/LLxeUDOnyjCbsTsXPDFup/kx8dYdVh66mtUaYvHHb1ByD4YyekaYniXt 492dEvzU6PCAsIO+ZqWPq89PlroH/cKun8zGbffdakHj5INhjNnmGiMRySgxzkjI tczTlcu6w0FPckbxn0AnMj2HAvOBGCfgcLNYfDGHOo+VfwfvLqsB0gb66T/fbYih IIQKgT9VEIn/CXdF7SlMCYempRSFnIGfwQA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjedvgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Oct 2023 08:08:07 -0400 (EDT) From: Thomas Monjalon To: Sunil Kumar Kori , Robin Jarry Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key Date: Tue, 17 Oct 2023 14:08:05 +0200 Message-ID: <2339972.BjyWNHgNrj@thomas> In-Reply-To: <20231009163610.1096092-1-skori@marvell.com> References: <20231009163033.1095213-1-skori@marvell.com> <20231009163610.1096092-1-skori@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Adding the script author, Robin. 09/10/2023 18:36, skori@marvell.com: > From: Sunil Kumar Kori > > This patch adds RSS key for CNXK platforms. CNXK platform uses > 48 bytes long key for hash calculations. > > For the same patch also updates help mesaages to provide range > information for supporting NICs/platforms. > > Also CNXK uses reta size as 64 so to get correct offset to retrieve > queue index, user must pass reta_size option as 64 i.e. -t 64. Can it be something automatic instead of asking the user to pass -t 64? > +# rss_key_default, see drivers/net/cnxk/cnxk_flow.c I don't see rss_key_default in drivers/net/cnxk/cnxk_flow.c > +# Marvell's cnxk NICs take 48 bytes keys > +RSS_KEY_CNXK = bytes( > + ( > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad, > + ) > +)