From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CB84D235 for ; Tue, 24 Jul 2018 15:39:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2A141219DA; Tue, 24 Jul 2018 09:39:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Jul 2018 09:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Kj35L0PzNx6wRBh8ZjtZ8JrtCx kfu2OYzyoMcFLuwC8=; b=VjXxEj5zclRgr6uu0yM5oIuV2fin8gUDXVQnF8KZY0 c55E/eQSi8ls4YyzpUvEvRut0tWH0B3m4cmyEO26vGolsaV/zxWX7YwEHJwbCwzM 1weoxyoLZZjpsu4p4rHhi3qrfkgZtGgCNVuN6bkPiCoHpaXXYgkBO++OYd2iudDC 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Kj35L0 PzNx6wRBh8ZjtZ8JrtCxkfu2OYzyoMcFLuwC8=; b=IRkSqAsckw5uQNobUXvMix rXNgamOHMgEinpePJhpL9uQ1KDs8vgDR676RTQePvhJFHjdD3aQduzdrEypbR0nd kx6LjVFCzKiIZGZdPx3nlfosxJjizNhRV2RtRfx7RttKuqNknAn7tLdDz6khoFX6 plj51esNcbhDcUfHAW8bsT81Vy0cgnLeDnQ303x40ojp5x9eAeJP9WHyUS3UjFKP SQPGOJYvvE8kxlxv725bk2p76AtzS02yVe6nscGnTJIodUiBRl1FpLy5csnXQcHr elnT/8qC5wOtEJxuP1453cC1+KafMxrGND1sr/jHSfeY8oDMAJ6Y6UeqnmGjhSoQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B7236E491A; Tue, 24 Jul 2018 09:39:37 -0400 (EDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: "Singh, Jasvinder" , "dev@dpdk.org" , "Pattan, Reshma" , "motih@mellanox.com" , "olivier.matz@6wind.com" , "Dumitrescu, Cristian" , "Mcnamara, John" Date: Tue, 24 Jul 2018 15:39:33 +0200 Message-ID: <2340431.Cz5R7fPtqY@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CCEE52@IRSMSX107.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <1925999.Zqez9Xlb98@xps> <8CEF83825BEC744B83065625E567D7C260CCEE52@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 13:39:40 -0000 24/07/2018 14:41, Iremonger, Bernard: > Hi Thomas, > > +John > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Important note: > > testpmd is currently really broken. > > We cannot have a RC2 until it is fixed. > > > > > > 24/07/2018 13:25, Thomas Monjalon: > > > 23/07/2018 12:44, Jasvinder Singh: > > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > > character (EOT) on the empty command line. > > > > > > Please describe what is the issue and what is the cause. > > > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > > > Reported-by: Mordechay Haimovsky > > > > Signed-off-by: Jasvinder Singh > > > > --- > > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > > > It is very suspicious to change the cmdline library. > > > If there is a bug in this library, it deserves a separate fix. > > > > > > Do you know what commit has broken testpmd? I think the "Fixes" line above is right: 0ad778b398c6 ("app/testpmd: rework softnic forward mode")