From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5FEC62C16 for ; Thu, 3 Aug 2017 22:35:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E98A5207FC; Thu, 3 Aug 2017 16:35:01 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 16:35:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=9VTrGF3SI3HqrAJ anDO3vN2TiidZwGfOeSo+SRmn4ZQ=; b=DMVpbLv50tj1mFxd8D3UugUz32dYPJk kouWE6eYqGQnyjL5TEfee7oxeJv5vDGTR0+GG4Q9BgfVPg9JwiPt86ryN2Ucv4cy zUKA94X5ZeXC00FvoTfeSV/yIRBQ1Xzc15nMrTMCe1daAnJROAzou2qsTKoe8VYu YUnQvjcUVbTg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=9VTrGF3SI3HqrAJanDO3vN2TiidZwGfOeSo+SRmn4ZQ=; b=MYnRXtu4 gOOTC130Y/1EFOF5a8EHp2rZprI2mHjYw3zwBK3nHF2fTKV07aYDRz4Sa5iQlY4B Q1x9oTynp1PWArZjqDRymb7G/yoQftCiEDAy5lTCbtySy8xTxXbDJZ8ZKmRA0fQC Y0B4Gmk6O/xM/Q5/rkVOF2RkUUOZozLGUJm1eWyOQ4S9LrE13WMo0orGVnaNVnOR 4w7bhXISSBqtn3kj3l0a3FhgZF9axLve1na8lAq5hLyUjdYVRfwtkCWhokh00rXI QWbpU7nJX2oT1eUpCNFY8esYV+Xz1aA5RNrruJ9zt+kjuWqFfUI71SdWJ5A5GAnj tGycazMZSgmmEw== X-ME-Sender: X-Sasl-enc: sUJVyWSNAsDrGubDYp4YdbH7rrttiQKzNGgHEx34yCt8 1501792501 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 6609A7E6AD; Thu, 3 Aug 2017 16:35:01 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org Date: Thu, 03 Aug 2017 22:34:59 +0200 Message-ID: <2340494.aB5PmPcCMt@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix blank line parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 20:35:02 -0000 03/08/2017 17:08, Gaetan Rivet: > When the output of an exec() slave definition is only a single newline > character, the fail-safe currently fails to parse the device with the > value returned by the rte_devargs library. > > This behavior is incorrect, because the fail-safe should make a > difference between the absence of a device, and an erroneous device > declaration. > > Fix the output sanitization in the case where no newline was at its end > and detect the special case of an absent device. The correct error code > is then returned. > > Fixes: a0194d828100 ("net/failsafe: add flexible device definition") > > Signed-off-by: Gaetan Rivet Applied, thanks