From: Thomas Monjalon <thomas@monjalon.net>
To: Sangjin Han <sangjin@eecs.berkeley.edu>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] lpm: fix build error on g++ with -O0 option
Date: Mon, 05 Jun 2017 15:12:20 +0200 [thread overview]
Message-ID: <2340758.4seTUyqQv4@xps> (raw)
In-Reply-To: <20170602093021.GB51388@bricha3-MOBL3.ger.corp.intel.com>
02/06/2017 11:30, Bruce Richardson:
> On Fri, Jun 02, 2017 at 05:07:46AM +0000, Sangjin Han wrote:
> > When rte_lpm.h is used on x86, -O0 option (no optimization at all)
> > given to gcc causes a compile error like this:
> >
> > error: the last argument must be an 8-bit immediate
> > i24 = _mm_srli_si128(i24, sizeof(uint64_t));
> >
> > -O0 option is useful for debugging and code coverage measurement, but
> > this error prevents DPDK programs from building. This patch replaces
> > "sizeof(uint64_t)" with a constant literal "8" to work around the issue.
> > The issue occurs on gcc/g++ versions from 4.8 to 5.
> >
> > Signed-off-by: Sangjin Han <sangjin@eecs.berkeley.edu>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied (with indent fix), thanks
prev parent reply other threads:[~2017-06-05 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 5:07 Sangjin Han
2017-06-02 9:30 ` Bruce Richardson
2017-06-05 13:12 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2340758.4seTUyqQv4@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sangjin@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).