From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4B6D11B2BA;
 Wed, 17 Jan 2018 23:19:39 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id CA17E20B84;
 Wed, 17 Jan 2018 17:19:38 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 17 Jan 2018 17:19:38 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=+yfEUnwjGGVXObCi053+1TvPu2
 l7ZGzjXDHrEJL5d6k=; b=DCSUdLgVLlc8YQjy1f1lJdz08z7oXb6jLUdhYB7Ssd
 N84L0nhAVWKHCD70CUz2wNHzpTKePz+Ql1CMeT2VM6criqwMqS9vqffkd5x0eyhh
 3tuExN9A3CRZXQX5CkwB3s0WeNObqwsxFmnclg5ma+8qJ2OOBdDD6XU8alLXezg6
 E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+yfEUn
 wjGGVXObCi053+1TvPu2l7ZGzjXDHrEJL5d6k=; b=TOc7cH27faXDmCQRdQsdOm
 xRH2ZXb53tOqj2xil0gg4slETtK2tSOQGphRmfSX2h+zIfz3R4EQTmEvTCw6gwy/
 kfRFfgmtFyEFirneo+jwDKoT9gZS9XOVCH4z8SiiYG2RafDZXY8yNU4bpEWCXY4J
 /HxFdn9AF49gTzTrFbQdhqKpvAk+USo/IV+grupuVglTCWLKqe5Caecs4atw8nLo
 5wZbbNNerAli/vnbxMK1FLgi15rNJVUDHnDpzFnXTQzwz9TI4t8qAhz+xAW2oqjo
 gkVEC1i4qnofCAgG9f2W9kyFjRETIokYDxkQxl2u2ZsMDMbH0WgTY6dSZg6sy5iw
 ==
X-ME-Sender: <xms:-stfWjSbmJrBaCXaGyrwXR5Y4YDQj4L7mDdFzuOkJ4g6XDn348_0mA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8224A7E2E6;
 Wed, 17 Jan 2018 17:19:38 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, declan.doherty@intel.com,
 Boris Pismenny <borisp@mellanox.com>, Aviad Yehezkel <aviadye@mellanox.com>,
 Radu Nicolau <radu.nicolau@intel.com>
Date: Wed, 17 Jan 2018 23:19:06 +0100
Message-ID: <2341214.iScQkZ5rM7@xps>
In-Reply-To: <3175063.1rsM1vLuis@xps>
References: <20180109162317.18183-1-ferruh.yigit@intel.com>
 <20180117215802.90809-1-ferruh.yigit@intel.com> <3175063.1rsM1vLuis@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix port id storage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jan 2018 22:19:39 -0000

17/01/2018 23:09, Thomas Monjalon:
> 17/01/2018 22:57, Ferruh Yigit:
> > port_id is now 16bits, update function parameter according.
> > 
> > Fixes: 4c270218aa26 ("ethdev: support security APIs")
> > Cc: stable@dpdk.org
> > Cc: declan.doherty@intel.com
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> 
> Obviously,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Not so obvious actually.
It is a good fix, but an API change.
This function was not declared experimental.
It must wait 18.05.

And the function has no doxygen!
And the function was placed randomly in the middle of struct declarations!
One more proof of the poor quality of rte_security stuff.