Re: [PATCH v6 1/9] net/zxdh: add zxdh ethdev pmd driver

[Thomas Monjalon <thomas@monjalon.net>]

16/10/2024 10:16, Junlong Wang:
> Add basic zxdh ethdev init and register PCI probe functions
> Update doc files
> 
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---
>  doc/guides/nics/features/zxdh.ini |  9 +++
>  doc/guides/nics/index.rst         |  1 +
>  doc/guides/nics/zxdh.rst          | 30 ++++++++++
>  drivers/net/meson.build           |  1 +
>  drivers/net/zxdh/meson.build      | 18 ++++++
>  drivers/net/zxdh/zxdh_ethdev.c    | 92 +++++++++++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_ethdev.h    | 44 +++++++++++++++
>  7 files changed, 195 insertions(+)

Release notes are missing.

[...]
> +++ b/doc/guides/nics/zxdh.rst
> @@ -0,0 +1,30 @@
> +..  SPDX-License-Identifier: BSD-3-Clause

A single space is enough here.

> +    Copyright(c) 2024 ZTE Corporation.
> +
> +ZXDH Poll Mode Driver
> +======================
> +
> +The ZXDH PMD (**librte_net_zxdh**) provides poll mode driver support
> +for 25/100 Gbps ZXDH NX Series Ethernet Controller based on
> +the ZTE Ethernet Controller E310/E312.
> +
> +- Learning about ZXDH NX Series Ethernet Controller NICs using

Active form is better: "Learn about"

> +  `<https://enterprise.zte.com.cn/sup-detail.html?id=271&suptype=1>`_.
> +
> +Features
> +--------
> +
> +Features of the zxdh PMD are:

Do you name your driver uppercase or lowercase?
Try to be consistent.

> +
> +- Multi arch support: x86_64, ARMv8.
> +
> +
> +Driver compilation and testing
> +------------------------------
> +
> +Refer to the document :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
> +for details.
> +
> +Limitations or Known issues
> +---------------------------
> +X86-32, Power8, ARMv7 and BSD are not supported yet.

Keep an empty line after a title.
What about RISC-V and Windows?


[...]
> +++ b/drivers/net/zxdh/zxdh_ethdev.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2024 ZTE Corporation
> + */
> +
> +#ifndef _ZXDH_ETHDEV_H_
> +#define _ZXDH_ETHDEV_H_

No need for the underscores at the beggining and end:
	ZXDH_ETHDEV_H

> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include "ethdev_driver.h"

The includes should be before extern "C"