From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B578E45B90; Mon, 21 Oct 2024 11:03:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DF1F4026B; Mon, 21 Oct 2024 11:03:31 +0200 (CEST) Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) by mails.dpdk.org (Postfix) with ESMTP id 287ED4021F for ; Mon, 21 Oct 2024 11:03:30 +0200 (CEST) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id C0D5111400D5; Mon, 21 Oct 2024 05:03:29 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Mon, 21 Oct 2024 05:03:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1729501409; x=1729587809; bh=1hH6a9vQKUJqlyV+M+de38uFRde3WuKcCJy0oN+hFnM=; b= A033SvRxZpqd0x3tK9IwZ7X0vYHguVONT3NqprvdY3z/l+K6dNCStHhXdImT77Wn FLQCiqbTHd07kG3i+dCZ338ZO+N0LgGJV29+k3YcPMOwyZiBAIC6vvGdTCJDVIeN v610peJ6DYmAa0Rlw6idqB5Vgr4uOoVjMyZ3i+7EL7vxjQi7R0kq+7oPTGurTck8 wC/fx7dniBd3i5RY4SyBKn8q+pzgz9nP5DIM1bMkPtokK3qFClnMnXh2Ajl6FvKr RLzpbAmckr58thB5AXV1ch0g2f+tXI1LFzgDosNHr63qXjNX/khASf8sPN5Ce6c7 m7y7q/Vi3PPwweASwUHxkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729501409; x= 1729587809; bh=1hH6a9vQKUJqlyV+M+de38uFRde3WuKcCJy0oN+hFnM=; b=b hPilTRaew5FjNAL6/LCHyBbzLRSdCJltCGKqe7b48RPX5fHdNs7a0L8flSPt+iCQ hqrkqJUr3g903ZqOr6PgLB5VQAe8SftHT8Q1hAx4DCsUkoFsm8UlPWnMBt4CWylt oM0/abYnESFBaFUDz7N9SqVeF1WOHyYJn/u32YyYpI5ndi3ubzd6ytrDRT0KuO3f N6ewOOBjj3HSqkfmrWnvuxvE1Edy0tRY5tI17sAZMIpNRjL1/B6qFpSOA75bB0tF rKc1RGjHS3xUeJFe4EXQbmxqM1QHlZnPelLpjYzbtvYx27PJgGb7nPF9r/Y9il4f W3atqUteh6Mckjzjvw+9w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeetkeeiveejvddvteetgfeuudetvdff hedvledvhfejgfehgfegvdffieehkeehvdenucffohhmrghinhepiihtvgdrtghomhdrtg hnnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohephedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepfigrnhhgrdhjuhhnlhhonhhgudesiihtvgdrtgho mhdrtghnpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohepshhtvg hphhgvnhesnhgvthifohhrkhhplhhumhgsvghrrdhorhhgpdhrtghpthhtohepfhgvrhhr uhhhrdihihhgihhtsegrmhgurdgtohhmpdhrtghpthhtohepfigrnhhgrdihohhnghdule esiihtvgdrtghomhdrtghn X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 05:03:28 -0400 (EDT) From: Thomas Monjalon To: Junlong Wang Cc: dev@dpdk.org, stephen@networkplumber.org, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v6 1/9] net/zxdh: add zxdh ethdev pmd driver Date: Mon, 21 Oct 2024 11:03:27 +0200 Message-ID: <23440715.ssLaC8jLEa@thomas> In-Reply-To: <20241016081647.1808333-2-wang.junlong1@zte.com.cn> References: <20241015054306.1751147-2-wang.junlong1@zte.com.cn> <20241016081647.1808333-1-wang.junlong1@zte.com.cn> <20241016081647.1808333-2-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/10/2024 10:16, Junlong Wang: > Add basic zxdh ethdev init and register PCI probe functions > Update doc files > > Signed-off-by: Junlong Wang > --- > doc/guides/nics/features/zxdh.ini | 9 +++ > doc/guides/nics/index.rst | 1 + > doc/guides/nics/zxdh.rst | 30 ++++++++++ > drivers/net/meson.build | 1 + > drivers/net/zxdh/meson.build | 18 ++++++ > drivers/net/zxdh/zxdh_ethdev.c | 92 +++++++++++++++++++++++++++++++ > drivers/net/zxdh/zxdh_ethdev.h | 44 +++++++++++++++ > 7 files changed, 195 insertions(+) Release notes are missing. [...] > +++ b/doc/guides/nics/zxdh.rst > @@ -0,0 +1,30 @@ > +.. SPDX-License-Identifier: BSD-3-Clause A single space is enough here. > + Copyright(c) 2024 ZTE Corporation. > + > +ZXDH Poll Mode Driver > +====================== > + > +The ZXDH PMD (**librte_net_zxdh**) provides poll mode driver support > +for 25/100 Gbps ZXDH NX Series Ethernet Controller based on > +the ZTE Ethernet Controller E310/E312. > + > +- Learning about ZXDH NX Series Ethernet Controller NICs using Active form is better: "Learn about" > + ``_. > + > +Features > +-------- > + > +Features of the zxdh PMD are: Do you name your driver uppercase or lowercase? Try to be consistent. > + > +- Multi arch support: x86_64, ARMv8. > + > + > +Driver compilation and testing > +------------------------------ > + > +Refer to the document :ref:`compiling and testing a PMD for a NIC ` > +for details. > + > +Limitations or Known issues > +--------------------------- > +X86-32, Power8, ARMv7 and BSD are not supported yet. Keep an empty line after a title. What about RISC-V and Windows? [...] > +++ b/drivers/net/zxdh/zxdh_ethdev.h > @@ -0,0 +1,44 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2024 ZTE Corporation > + */ > + > +#ifndef _ZXDH_ETHDEV_H_ > +#define _ZXDH_ETHDEV_H_ No need for the underscores at the beggining and end: ZXDH_ETHDEV_H > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#include "ethdev_driver.h" The includes should be before extern "C"