From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E925DAAD8 for ; Tue, 17 Apr 2018 00:23:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 78C4121F09; Mon, 16 Apr 2018 18:23:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Apr 2018 18:23:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=QgbtWdYtDrkNBKz60e4V9IyK+l YEcdeUREGk/hYleSs=; b=sBooFB+2gpMvWXcVPcdlGenM5BPsaDa+tZFlaCPsdf 2p4bYeCgPXEOBwHtG8pkfNlQHBIOOHQ6jCfYW18jTVMj3vXwQItOISkIK8eHV1ng lto0+324mBujr3kjw4vMZBo0TmCOEUuAv67BB0oZO3E7ZypdiPVWoGpZaJxaxIMx U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QgbtWd YtDrkNBKz60e4V9IyK+lYEcdeUREGk/hYleSs=; b=kcbvIkyS4P8/zddMnYln0T IqV5tA7JtpIVdBVe3TSw8JnfZjtMdfqTNv7jHzBZ4s7fdzveJwlRrKnat9lC1UiL pilMaxpZsdJqyQ9JlguBRF6d37J7pu+G1Mm4U5Qx/uSdSLwHYCBRg1lHC6ks0WQQ fFhQ6+2sYse8vjbuz+q4UN3ZPjOpCYiqwIVn3U3rPj4F468kmi1Nw6i3hqXo6mRb VNQl+WYFELN0IV43K8Fw/7/hfMlzlLrs62FZlWffA5RWruEgx5Gmenk3IxpZZ+BI eDpYxO73Y0DW1tQB82eZSieMX7iwJJqB7ponJsOyVq8CcVQghikk5k/D3w9Sgoqg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 64A90E4925; Mon, 16 Apr 2018 18:23:06 -0400 (EDT) From: Thomas Monjalon To: Xueming Li Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro , Shahaf Shuler , Olivier Matz Date: Tue, 17 Apr 2018 00:23:05 +0200 Message-ID: <2345236.0ahlb2178t@xps> In-Reply-To: <20180413110218.105894-3-xuemingl@mellanox.com> References: <20180413110218.105894-1-xuemingl@mellanox.com> <20180413110218.105894-3-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/5] ethdev: introduce new tunnel VXLAN-GPE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 22:23:08 -0000 13/04/2018 13:02, Xueming Li: > +struct vxlan_gpe_hdr { > + uint8_t vx_flags; /**< flag (8). */ > + uint8_t reserved[2]; /**< Reserved (16). */ > + uint8_t proto; /**< next-protocol (8). */ > + uint32_t vx_vni; /**< VNI (24) + Reserved (8). */ > +} __attribute__((__packed__)); minor nit: the field comments could be aligned