From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@amd.com>,
fengchengwen <fengchengwen@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, neerav.parikh@amd.com
Subject: Re: [PATCH v2] doc: update size parameter details
Date: Mon, 18 Mar 2024 03:47:06 +0100 [thread overview]
Message-ID: <2346427.n0HT0TaD9V@thomas> (raw)
In-Reply-To: <bbaa12e5-0d0f-708a-cc2c-efe390d85aa5@huawei.com>
12/03/2024 07:17, fengchengwen:
> Sorry for same reply,
>
> @Vipin,
> the title should reflect which submodule, so pls add prefix: test/dma-perf:
No it should be app/dma-perf.
If not sure about a prefix, you may check the git history for the directory.
> Suggest: test/dma-perf: refine size parameter details in doc
> Just a suggestion, you could refine it.
>
> On 2024/3/12 14:07, fengchengwen wrote:
> > Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Please add your ack below the sign-off for clearer reply chain.
> > On 2024/3/12 12:22, Vipin Varghese wrote:
> >> For configuration parameters `mem_size` and `buf_size` are represented
> >> as megabytes and bytes respectively in application. Update the
> >> documentation and to represent the same.
> >>
> >> V2 Changes:
> >> - add mem_size and buf_size in config.ini, suggested by Chengwen.
> >>
> >> Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
Applied, thanks.
prev parent reply other threads:[~2024-03-18 2:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 10:45 [PATCH] " Vipin Varghese
2024-03-06 6:08 ` Varghese, Vipin
2024-03-07 13:27 ` fengchengwen
2024-03-07 15:50 ` Varghese, Vipin
2024-03-12 4:22 ` [PATCH v2] " Vipin Varghese
2024-03-12 6:07 ` fengchengwen
2024-03-12 6:17 ` fengchengwen
2024-03-18 2:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2346427.n0HT0TaD9V@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=neerav.parikh@amd.com \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).