From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3051D43CDC;
	Mon, 18 Mar 2024 03:47:14 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F155A402E5;
	Mon, 18 Mar 2024 03:47:13 +0100 (CET)
Received: from wfout4-smtp.messagingengine.com
 (wfout4-smtp.messagingengine.com [64.147.123.147])
 by mails.dpdk.org (Postfix) with ESMTP id 8C8DA402BF
 for <dev@dpdk.org>; Mon, 18 Mar 2024 03:47:12 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailfout.west.internal (Postfix) with ESMTP id 151BF1C00077;
 Sun, 17 Mar 2024 22:47:08 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sun, 17 Mar 2024 22:47:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm2; t=1710730028;
 x=1710816428; bh=hi3li7OM4Q/HVCt8bNc2sDQXXE69DXTEeMd8tekZz4o=; b=
 f57vG1zMYR177NRzxirVzAlscTO101k/hCn/wVic0HqbRhOC88r7NZwquH2SAuRC
 antYwnakS8NSN81vrXgGbEjkIjHI2KH6x8NpWzb9ADUD2VTRWjdQigyGoWfuNr/6
 X0tBj5cTReeztHb453FD1Ph84oe6rMYRpCgwvf9nfHNZG5jXFWuH7s2Wz6au11fv
 iWnokT9SUg4HbBpnDRd/DJGNlIXgj3nQ5cKut38/BeKB4k77nRPwoJsUr3uibF31
 zZcOLOpUdPHDJwAJ0AP3Bw6vna7DdTmdc0Jo6HxGq9Is6rskjcmN3+MvcPVrD+A+
 kQCH9OET7Kwsd/dKTKLOBA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1710730028; x=
 1710816428; bh=hi3li7OM4Q/HVCt8bNc2sDQXXE69DXTEeMd8tekZz4o=; b=s
 2K+8RoDyrvkkvcApZVlFcL7fc2NekqZOTmYYLpAxV6r1lhaTtrH2pmnDilrT/JNT
 kQP4Q2IlpjYf6DNpM3CkYwftE3nmIfQjOJaprEKEYMu10fCRC2RjawgG0GhsRa4Z
 vw41mQZlu3XunqAad2cp33KPTavR13pIq6/ir0ysCr6vypQIIBePlqcNaPAv4Pnz
 rmT5YHv0WNwi3AO4wx6fSMbbEYciDB+AI6RtrnXdJCvbG+juaAqGXNa7lACxgQtF
 YnlTl70gXZehYbS0tq84P7EK77QdXZe04wuURJf9qq2kUWEkObaVhmXua9cu6mfS
 SnyEccHQ1ID0vIX8zJqPA==
X-ME-Sender: <xms:LKv3ZVR-PwvOadjVN4vIyK1nPATvF7w2kZjaPDttNcaiycURhWBXpg>
 <xme:LKv3Zexd7mpgshwtwuiZxCkvdDHyqRKZh3O1aMaozzdXTlvOAUMlzY8JBuWHvTKSr
 1CotgSPakCfypoPUw>
X-ME-Received: <xmr:LKv3Za1d0OSPg3VZJidMMpuUZhZlBPh9495BiNyRaAng4KDWpAm16DFPR-NQwrKtmoRBEj3u_4KjLLTCUkJS8z3DOQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrkeeigdehudcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg
 vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:LKv3ZdC8QEefW9mdyGZf1ZPmT2Rjb1hD5X2wkRHC32luJtHbySF42w>
 <xmx:LKv3ZegINyyJS82XrDRA-YKtcYUSmwElasxQ1CLuofKa32nwLw3Apg>
 <xmx:LKv3ZRrXNSyhHl75_o4Hhot9oBVbV_D5khjuOTO0_flaCW4Hs9rsyQ>
 <xmx:LKv3ZZiDw3xJMlO1BQvcm4BLmqSl7qF5kOvfjFj41EY8Lw4AEXgUqA>
 <xmx:LKv3ZZUgmcNnWzgZ-oXCzmimCSAivZSfAPczfro9cm-Tn9QDLEzit5SvqMM>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 17 Mar 2024 22:47:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@amd.com>,
 fengchengwen <fengchengwen@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, neerav.parikh@amd.com
Subject: Re: [PATCH v2] doc: update size parameter details
Date: Mon, 18 Mar 2024 03:47:06 +0100
Message-ID: <2346427.n0HT0TaD9V@thomas>
In-Reply-To: <bbaa12e5-0d0f-708a-cc2c-efe390d85aa5@huawei.com>
References: <20231212104508.1941-1-vipin.varghese@amd.com>
 <83c1f9b2-74f1-6d78-ae6c-a89392a9e88d@huawei.com>
 <bbaa12e5-0d0f-708a-cc2c-efe390d85aa5@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

12/03/2024 07:17, fengchengwen:
> Sorry for same reply,
> 
> @Vipin,
> the title should reflect which submodule, so pls add prefix: test/dma-perf:

No it should be app/dma-perf.
If not sure about a prefix, you may check the git history for the directory.

> Suggest: test/dma-perf: refine size parameter details in doc
> Just a suggestion, you could refine it.
> 
> On 2024/3/12 14:07, fengchengwen wrote:
> > Acked-by: Chengwen Feng <fengchengwen@huawei.com>

Please add your ack below the sign-off for clearer reply chain.

> > On 2024/3/12 12:22, Vipin Varghese wrote:
> >> For configuration parameters `mem_size` and `buf_size` are represented
> >> as megabytes and bytes respectively in application. Update the
> >> documentation and to represent the same.
> >>
> >> V2 Changes:
> >>  - add mem_size and buf_size in config.ini, suggested by Chengwen.
> >>
> >> Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>

Applied, thanks.