From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Nicolás Pernas Maradei" <nico@emutex.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop error
Date: Thu, 09 Oct 2014 21:10:21 +0200 [thread overview]
Message-ID: <2347562.QcBRlqmUyU@xps13> (raw)
In-Reply-To: <20141006145020.GE22304@hmsreliant.think-freely.org>
> > New in Patch v2:
> >
> > - Fixes an issue in eth_dev_start/stop where a single interface was always
> > opened/closed even though pcap files had been selected for rx/tx streams.
> > - The link_status was not being properly updated in case of using a single
> > interface for rx/tx streams.
> >
> > On 2014-10-04 23:24, Nicolás Pernas Maradei wrote:
> > >
> > >librte_pmd_pcap driver was opening the pcap/interfaces only at init time
> > >and
> > >closing them only when the port was being stopped. This behaviour would
> > >cause
> > >problems (leading to segfault) if the user closed the port 2 times. The
> > >first
> > >time the pcap/interfaces would be normally closed but libpcap would throw
> > >an
> > >error causing a segfault if the closed pcaps/interfaces were closed again.
> > >This behaviour is solved by re-openning pcaps/interfaces when the port is
> > >started (only if these weren't open already for example at init time).
> > >
> > >Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Applied
Thanks
--
Thomas
prev parent reply other threads:[~2014-10-09 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <005307>
2014-10-04 22:24 ` Nicolás Pernas Maradei
2014-10-05 18:37 ` Nicolás Pernas Maradei
2014-10-06 14:50 ` Neil Horman
2014-10-09 19:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2347562.QcBRlqmUyU@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nico@emutex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).