Re: [dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API

[Thomas Monjalon <thomas@monjalon.net>]

09/11/2021 03:10, Narcisa Ana Maria Vasile:
> On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote:
> > 09/10/2021 09:41, Narcisa Ana Maria Vasile:
> > > From: Narcisa Vasile <navasile@microsoft.com>
> > > 
> > > As a new API for threading is introduced,
> > > a set of unit tests have been added to test the new interface.
> > > The tests verify that:
> > >  * mutexes and barriers behave as expected
> > >  * thread properties are applied correctly
> > >  * the thread id is retrieved correctly
> > >  * thread creation/destruction works properly
> > 
> > Please make each test part of the patch implementing the feature.
> > Thanks
> > 
> Makes sense, but most of these unit tests use rte_thread_create and
> rte_thread_join to handle the creation and cleanup of the threads
> that are being tested, so I'm forced to have this test patch at the end.

You mean you cannot start the series with implementing these 2 functions?

> I could still break it up into smaller patches, one for each test category
> (mutex, attributes, etc) if you want. 

I would like to see features built & tested atomically and progressively.