From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44FA6A0C4B; Tue, 9 Nov 2021 09:32:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C00D40687; Tue, 9 Nov 2021 09:32:13 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 08E6340151 for ; Tue, 9 Nov 2021 09:32:12 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 40821580530; Tue, 9 Nov 2021 03:32:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 09 Nov 2021 03:32:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 5MeuaOiSJmz0e2248aKzNzGt31ThvAXl66Kn7Ct098M=; b=EyiuDjlRLUaKY26/ XC3RyBykGtuboeS7BR+hW1sNF1WBIZi7Es0ahJoMsGTfU57wssru20v8A5cpWjHM fIzCOT5v41yRsWmK6FxBc+XyhdEL58dooUV0ZVF6xPDPpnSrEXS05YUmX+GRmteD 4FKDnPJNT0zxXl6lPGia7MuMc/2iccOTKPFldkPEwRe5VM7E7kwMKhyaJQTO51t4 uEhBoDSy66za+LECytkNaTc4lwNUPMFZLMzwuMR5VfJh4yUiThgf74utOalCEVM1 hln3Co1McupHbUN5qq8wMrM5rHxbhq7hLCCMlt5SQMajWHkBAGRa6EbgB+muq63f F/Py7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=5MeuaOiSJmz0e2248aKzNzGt31ThvAXl66Kn7Ct09 8M=; b=fxRTrW2eTTxIKOS2FuxAbC6ec2kB2w3oHy7jJLf87Z/PV3gW/3fKrC4wD rrWbLnFq2OTynwHKBrmw5n6ZwceE5l+Bge3CEf3zxr/tdyhkoWOMTbsQI5rSaq3n 905Nr3N86oAVniYS6NvGnu2QIapO0o6g092o0czSK4GBS755fUeb0t93siXPxeZ/ oJhUg72dmwW07tvPAZKjaTKP4egXk5Um427xBtjVzvExfmv5sz3Y+XCyy3B34tZ1 A68SZLc25m+1qLMmIu+tGLdDOWdxbuPY3+ECipEKvtXmeNmzP4C3usTUUe3CP5DS Cf7X3Z/AKBRqZO5L6Vw+U3pk0nsgw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefgdduudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Nov 2021 03:32:09 -0500 (EST) From: Thomas Monjalon To: Narcisa Ana Maria Vasile Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, khot@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Date: Tue, 09 Nov 2021 09:32:08 +0100 Message-ID: <2349846.SAT7s3pbht@thomas> In-Reply-To: <20211109021048.GF12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1633732841-17873-1-git-send-email-navasile@linux.microsoft.com> <4938958.YfKOMBFpFK@thomas> <20211109021048.GF12569@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2021 03:10, Narcisa Ana Maria Vasile: > On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote: > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > From: Narcisa Vasile > > > > > > As a new API for threading is introduced, > > > a set of unit tests have been added to test the new interface. > > > The tests verify that: > > > * mutexes and barriers behave as expected > > > * thread properties are applied correctly > > > * the thread id is retrieved correctly > > > * thread creation/destruction works properly > > > > Please make each test part of the patch implementing the feature. > > Thanks > > > Makes sense, but most of these unit tests use rte_thread_create and > rte_thread_join to handle the creation and cleanup of the threads > that are being tested, so I'm forced to have this test patch at the end. You mean you cannot start the series with implementing these 2 functions? > I could still break it up into smaller patches, one for each test category > (mutex, attributes, etc) if you want. I would like to see features built & tested atomically and progressively.