Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check

[Thomas Monjalon <thomas@monjalon.net>]

11/10/2021 22:38, Chautru, Nicolas:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 13/08/2021 18:51, Nicolas Chautru:
> > > Adding a missing operation when CRC16
> > > is being used for TB CRC check.
> > >
> > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > > ---
> > > --- a/doc/guides/rel_notes/release_21_11.rst
> > > +++ b/doc/guides/rel_notes/release_21_11.rst
> > > @@ -84,6 +84,7 @@ API Changes
> > >     Also, make sure to start the actual text at the margin.
> > >     =======================================================
> > >
> > > +* bbdev: Added capability related to more comprehensive CRC options.
> > 
> > That's not an API change, the enum symbols are the same.
> > Only enum values are changed so it impacts only ABI.
> 
> Hi Thomas, 
> How is that not a API change when new additional capability are exposed? Ie. new enums defined for new capabilities. 

API change is when the app source code has to be updated.
ABI change is when the app binary has to be rebuilt.

> I think I see other similar cases in the same release notes " * cryptodev: ``RTE_CRYPTO_AEAD_LIST_END`` from ``enum rte_crypto_aead_algo ...".

I don't see this one.

> You know best, just checking the intent, maybe worth clarifying the guideline except in case this is just me. 

Given my explanation above, how would you classify your change?