From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9FC8A0C47; Tue, 12 Oct 2021 08:53:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DDAE4067C; Tue, 12 Oct 2021 08:53:13 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id EC37C40142 for ; Tue, 12 Oct 2021 08:53:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8B6BE5C00A6; Tue, 12 Oct 2021 02:53:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 12 Oct 2021 02:53:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= kDWUaqMvaN7HM5vdg/6uiFcq1KeQz0I0X5RBX4zraV4=; b=SnqV1bWnLUZ7wjqD DKoM7GDDuq2i3eMaJwlXcoZj0FqEXsFGvwzhC6wsD0ZuF0ig8BnA2feP7PqFTDvn ExAEDVXD+yz35RM5VX9LvKOJgXwfbmehkt+bg9vreh05pinlfdkREsIpOkyMbyI6 h8w2KQY9q8lUco7+gEJRElzj/dpbSv0LxLzEs/arLkgEKv4sMeDF8Gq8A186/2pW 0z++i6xubakQOnQeckKD470oSvHZpW5jPuljSBWk0J5J2nkKfOzSXNjeIgqGUBcE vv0LnDvTbXU+b5ALcSm89o8tCKYesjPD8Bl8SHBqwv+BlFVrtPh/3GB/IahLpSVl bXRwfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=kDWUaqMvaN7HM5vdg/6uiFcq1KeQz0I0X5RBX4zra V4=; b=UGJX//amNI2harisIaIQTzd5vWQmewoUu1Porgv34HIH5cJCkTFzEeCy3 vGUbcGZz90OkrHdpdz0V2lHuVLQImGe16AjCnUDkUVnWE5u5JlQuSMs/iN7YvQe8 rcVPs2XNn0l3m+Ar4y2Ki13CjjQua3b9z2v9sacTE+88OQIoyF2W9uqDBbLSBldR 7/3/atnHN7jNIqjUYNBZzPRbqhEP/Ro6N1YfG3NXpMQORs+4WU5x2AEwaP0kgZBj m6RrnwLapvnGLCrwONLg7F6yLGIdFHdNiw0L1TCUUUoNtjB0CnN5ElL049Ro8mh/ 5Ii3k+BcjLIs5QM3M0l08UNMFIMXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtjedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Oct 2021 02:53:09 -0400 (EDT) From: Thomas Monjalon To: "Chautru, Nicolas" Cc: "gakhil@marvell.com" , "dev@dpdk.org" , "trix@redhat.com" , "hemant.agrawal@nxp.com" , "Zhang, Mingshan" Date: Tue, 12 Oct 2021 08:53:07 +0200 Message-ID: <2349964.oiB3URGJAo@thomas> In-Reply-To: References: <1628873485-30596-1-git-send-email-nicolas.chautru@intel.com> <1702526.DCS0tWCQBP@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/6] bbdev: add capability for CRC16 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/10/2021 22:38, Chautru, Nicolas: > From: Thomas Monjalon > > 13/08/2021 18:51, Nicolas Chautru: > > > Adding a missing operation when CRC16 > > > is being used for TB CRC check. > > > > > > Signed-off-by: Nicolas Chautru > > > --- > > > --- a/doc/guides/rel_notes/release_21_11.rst > > > +++ b/doc/guides/rel_notes/release_21_11.rst > > > @@ -84,6 +84,7 @@ API Changes > > > Also, make sure to start the actual text at the margin. > > > ======================================================= > > > > > > +* bbdev: Added capability related to more comprehensive CRC options. > > > > That's not an API change, the enum symbols are the same. > > Only enum values are changed so it impacts only ABI. > > Hi Thomas, > How is that not a API change when new additional capability are exposed? Ie. new enums defined for new capabilities. API change is when the app source code has to be updated. ABI change is when the app binary has to be rebuilt. > I think I see other similar cases in the same release notes " * cryptodev: ``RTE_CRYPTO_AEAD_LIST_END`` from ``enum rte_crypto_aead_algo ...". I don't see this one. > You know best, just checking the intent, maybe worth clarifying the guideline except in case this is just me. Given my explanation above, how would you classify your change?