From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E7F174C9D for ; Tue, 25 Sep 2018 11:04:22 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 52BFA21AE8; Tue, 25 Sep 2018 05:04:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 25 Sep 2018 05:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=oPvD8CDVPR8e7nSXW55qS3fj6I Uy8BPtvAdEC3ZIuv8=; b=DRu6vnFctUdUT+UVcUERoCWJ65GuBA0PRcVYvbPSsn Njkp+Z9HSVPES3Y0GNR262C2kXrh8HXyuX1nMtWfJF8WR9TZx35PeuQNUOXAZEgk 7TdFVTUJwohypWuyZ/EbnIcSSFMKL4OMP8KguHBLj/zQGuGbTTchBk4oCWhgYSAy A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oPvD8C DVPR8e7nSXW55qS3fj6IUy8BPtvAdEC3ZIuv8=; b=HZ63xwl2L7L59lxe8lrD0r WAH7oG3q7YUD9+P0izNXH0f0zNtVaBD2HneFQaJ7l/3qEsxkrUp0Ws/5LWwfBEPS dPSKsV584l7oCDGeg4k3c8AevuR6dHuC02Mc8PtrDzQgZLglX2nGT4VmUbEk7rV5 WeO1HLFl4q0Zvx8WEDdI7HfiAKQEXkMuPEU9DcdU+NfLZVGm2Fz+7vsUZ6g24fLd +K9czJATyI0f75wSuKK2D5R3D+LHQxir3t6YA13ZObmxhGktyBK8pnmHp9dnnkGr JVzK6OFtYKxMbbN8He+XlAI4iThXTlw2S0TRtyjX38iE3RqWuSJNQQQA4Wn08GIA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 38DC6102D6; Tue, 25 Sep 2018 05:04:18 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Rahul Lakkireddy , Wenzhuo Lu , Qi Zhang , Xiao Wang , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Yong Wang , dev@dpdk.org Date: Tue, 25 Sep 2018 11:04:17 +0200 Message-ID: <2353010.843Iz9OGFG@xps> In-Reply-To: <840d806c-d75c-f990-5883-1315ea37f95b@intel.com> References: <20180920001853.23454-1-thomas@monjalon.net> <1920676.XclAJlGjTg@xps> <840d806c-d75c-f990-5883-1315ea37f95b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 09:04:23 -0000 25/09/2018 10:03, Ferruh Yigit: > On 9/24/2018 5:59 PM, Thomas Monjalon wrote: > >>> --- a/drivers/net/ixgbe/ixgbe_rxtx.c > >>> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >>> @@ -2025,7 +2025,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > >>> struct ixgbe_rx_entry *next_rxe = NULL; > >>> struct rte_mbuf *first_seg; > >>> struct rte_mbuf *rxm; > >>> - struct rte_mbuf *nmb; > >>> + struct rte_mbuf *nmb = NULL; > >> > >> This change is unrelated. Can we separate this one? > > > > Yes it looks unrelated but it becomes necessary when including stdbool.h. > > I don't know the root cause, but yes, it may deserve a separate commit. > > Maybe an ixgbe maintainer can take care of it? > > Why becomes necessary? Does it give a build warning etc? > My concern is this is in data path, one extra assignment, it would be better to > confirm it is really needed. Yes I had a compilation error. If you cannot reproduce it, I will try to re-run my compilation tests.