From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CB3F02C16;
 Thu,  3 Aug 2017 22:10:52 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 731F32098B;
 Thu,  3 Aug 2017 16:10:52 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 03 Aug 2017 16:10:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=s/KHyYVMYBZiTee
 PxxfIbH9Snbq2m91WTql4+5U+nts=; b=Mfb9Igo+nbfZEI5Az/3XhUs2SfZNxQY
 CIQo52tEpOnBOdWg9dHAeGgua2W+7G6ptuiOuVfNLeGHKKpxj35aS7Tao6igepay
 fOGlLZQJI63y5zFf657oO+iAc6IZl/U2Z4vfCnCI3Cs85m7x5BN/99wbc66PVjLs
 1N2N/8bVrZLk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=s/KHyYVMYBZiTeePxxfIbH9Snbq2m91WTql4+5U+nts=; b=fdQkscPL
 ZW67tzJSQ+QLrYPTXIGPDzfM54O7IOvs49WwPUb1+lU1mLkvc81Pb2i67KxTqDnF
 utqp0VM4q4eVCRI9IBRfO6e2gK5aWn204HVvMi42bm+vrD2d/vqaNCBJbV8sJkM9
 u31otEZSfkKdivJBfGmYG9o1oNksiN+K5vXlS0sI3gGE+r1dwPMdvcC95H9GQRyK
 ut9wuaoflb3sbF48S1rYaWokLhfHNkDOwMu9jftjPuI/K05ynKnU9zOHTGX18ojq
 DAsxV8eHCHoV8UOr2zQzRER1IUtsFZsTsEqd15vXrRvQFNhQml1FTSbC6VPoQ8PO
 cw78A4UiVe6nTA==
X-ME-Sender: <xms:TIODWYdNe_ONHACaNdEeZWmCSqfoTV9ylOdDAaGjhXMPn_uveKTaUw>
X-Sasl-enc: Eo7+YbWITR9i3bScfOo59Ktm9oICbKCRas7SfWT/h2br 1501791052
Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196])
 by mail.messagingengine.com (Postfix) with ESMTPA id 028BB246C4;
 Thu,  3 Aug 2017 16:10:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
 yliu@fridaylinux.org, stable@dpdk.org
Date: Thu, 03 Aug 2017 22:10:50 +0200
Message-ID: <2354798.sDqUmiiPUi@xps>
In-Reply-To: <367875c7-d9f8-03e2-f7af-07e98cd5f772@redhat.com>
References: <1501578081-191381-1-git-send-email-tiwei.bie@intel.com>
 <367875c7-d9f8-03e2-f7af-07e98cd5f772@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] vhost: make the page logging atomic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 20:10:53 -0000

01/08/2017 14:05, Maxime Coquelin:
> On 08/01/2017 11:01 AM, Tiwei Bie wrote:
> > Each dirty page logging operation should be atomic. But it's not
> > atomic in current implementation. So it's possible that some dirty
> > pages can't be logged successfully when different threads try to
> > log different pages into the same byte of the log buffer concurrently.
> > This patch fixes this issue.
> > 
> > Fixes: b171fad1ffa5 ("vhost: log used vring changes")
> > Cc:stable@dpdk.org
> > 
> > Reported-by: Xiao Wang<xiao.w.wang@intel.com>
> > Signed-off-by: Tiwei Bie<tiwei.bie@intel.com>
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied, thanks