From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48DA6A04B5; Wed, 16 Sep 2020 17:58:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23EE91C433; Wed, 16 Sep 2020 17:58:42 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 65E3F1C2F9 for ; Wed, 16 Sep 2020 17:58:40 +0200 (CEST) IronPort-SDR: nXwWpYnUo2zK4jJBzAKSkJm9sWX7x6L8IyGPhSbe9mZqnUpGc87J4On5wj9iQeN2YIPBDAPLNj StQULJI3hB5A== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="221054325" X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="221054325" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 08:58:39 -0700 IronPort-SDR: Km92vEMeXp79myPBGfkIDu+zQ+Ti8AFLJF4W4KuH7fvgf5fR3m/GAo24dpDzMwjAp5WcYGvpNV 7CrtzbUdDBig== X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="483361718" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.248.202]) ([10.213.248.202]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 08:58:35 -0700 To: "Wei Hu (Xavier)" Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Shahaf Shuler , Qi Zhang , Andrew Rybchenko , Thomas Monjalon , dev@dpdk.org, xavier.huwei@huawei.com References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200820014204.25035-1-huwei013@chinasoftinc.com> <20200820014204.25035-5-huwei013@chinasoftinc.com> <1f017605-c7cf-78c3-b1c1-0827a8e6f8b6@intel.com> <677a3cb4-cff0-56f3-bfee-422d4742ddd8@chinasoftinc.com> From: Ferruh Yigit Message-ID: <23553e15-64c3-78a3-193a-7c9ad04d803c@intel.com> Date: Wed, 16 Sep 2020 16:58:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <677a3cb4-cff0-56f3-bfee-422d4742ddd8@chinasoftinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/2020 10:23 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit > > On 2020/9/15 0:31, Ferruh Yigit wrote: >> On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: >>> From: Huisong Li >>> >>> Currently, the information of Rx/Tx queues from PMD driver is not displayed >>> exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" >>> and "ports[pid].tx_conf" maintained in testpmd application may be not the >>> value actually used by PMD driver. For instance, user does not set a field, >>> but PMD driver has to use the default value. >> Overall the question is why testpmd maintains the config values itself? >> If this is testpmd implementation problem that is no big deal, but if >> our APIs are forcing applications to maintain local copies that is >> something to fix I think, which may lead the differences in application >> copy and more troubles as you are fixing here. > > I think it is a minor problem about displaying some information about > testpmd. > > And it has no impact on the usage of application > Agree this specific issue is minor problem, I already give the review tag. And if the issue only concerns testpmd, still no big issue. But I was questioning if this is sign of a design problem in DPDK APIs, which matters. A simple question, why testpmd maintains the local version of the configuration? And follow up can be, Will it cause any functional problem if application always request configs from DPDK when needed instead of maintaining local copies? Are we missing APIs to do this? > > Thanks, > > Xavier > >>> This patch fixes rxtx_config_display so that the information of Rx/Tx >>> queues can be really displayed for the PMD driver that implement >>> .rxq_info_get and .txq_info_get ops callback function. >>> >>> Fixes: 75c530c1bd5351 ("app/testpmd: fix port configuration print") >>> Fixes: d44f8a485f5d1f ("app/testpmd: enable per queue configure") >>> Cc:stable@dpdk.org >>> >>> Signed-off-by: Huisong Li >>> Signed-off-by: Wei Hu (Xavier) >> Reviewed-by: Ferruh Yigit >>