From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ED7845B60; Thu, 17 Oct 2024 18:05:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDDD54025F; Thu, 17 Oct 2024 18:05:57 +0200 (CEST) Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id C4FB24021E for ; Thu, 17 Oct 2024 18:05:56 +0200 (CEST) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 563B513806FE; Thu, 17 Oct 2024 12:05:56 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Thu, 17 Oct 2024 12:05:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729181156; x=1729267556; bh=mT6Nd5L5L5SJyxkPzcvIwcMiUzXCFzaxrMNU9Fcj/7A=; b= WNWum78ux8fFiT9VD3ghz2vvb2nUugN6uatcVOVFH+h+gOhUec2/GaOwy51IQ5wi WpTKcn+lT2M6UhnSYfsTfpzQ9jk9tX3hy8TP2xMtiy4Fp1yWLLlBs6aS9dJWPZ++ 827eVouf/t2ZpDMQdg9Nl6h3+q2SCfq9u3keSz3daeC6gbjVA5DbgT6eKLoJR/4A 8T4gs7HcB8WdlE//tkF6UMFES3iBIIa5Q8rBB8BkU4NFS+X6ykOgOESCFY4xqodb 3mERh2sXhEovMyV4PyHOfXo++orvc6tgi2mqsBMx6hOWyUVdIRuxwjJMiPARCgIj loLHjqrEf1Ef2ikjgaxvfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729181156; x= 1729267556; bh=mT6Nd5L5L5SJyxkPzcvIwcMiUzXCFzaxrMNU9Fcj/7A=; b=L dpm73s/wyF9ett1Q0OvSSVCP567pQ+wt5Sut09PIHeYbPQzvv/g1d0WT1xKf1TDT MvB2N/Q8mHueVmsOzPRzG+HrbJToCrauMK1zA5DyGuixsBnrHpT8wM/JsVrgnPFj cQIJI3G+hWaZyT7TC/kUmPo36OXce/o8J3wv+R3H0CKWdZrv0c/49Soe9h2swuPv 2IUR73+9dUVM3kkKgGx0Xcy0GUvqi5gMqxCY+jPZPRCKExwu9QBG0zGpHumjlQKD f3rs89i8FGOCQIEOi/1YQhQKM1gnqNE8P0fs82iUDyR05/HsiDNlYxzaFYGh3OvW Gf9EGUSpvEausj+Uqoxfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehuddgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeekfeehfedtgedtjeehueeutdfgleef ieevkeeikeelkefflefgtdevieehheffudenucffohhmrghinhepughpughkrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthdpnhgspghrtghpthhtohepiedpmhhouggvpehsmh htphhouhhtpdhrtghpthhtoheptghhrghohihonhhgrdhhvgestghorhhighhinhgvrdgt ohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtghpthhtohepohhsshdqug hrihhvvghrshestghorhhighhinhgvrdgtohhmpdhrtghpthhtoheplhhonhhgrdifuhes tghorhhighhinhgvrdgtohhmpdhrtghpthhtohepphgvnhhgrdiihhgrnhhgsegtohhrih hgihhnvgdrtghomhdprhgtphhtthhopehvihhgnhgvshhhrdhpuhhruhhshhhothhhrghm rdhsrhhinhhivhgrshesvghrihgtshhsohhnrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Oct 2024 12:05:55 -0400 (EDT) From: Thomas Monjalon To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, Long Wu , Peng Zhang , Vignesh PS Subject: Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size Date: Thu, 17 Oct 2024 18:05:54 +0200 Message-ID: <2356351.KTMopqUuYO@thomas> In-Reply-To: <20241011032412.3672788-3-chaoyong.he@corigine.com> References: <20240624020355.3712965-1-chaoyong.he@corigine.com> <20241011032412.3672788-1-chaoyong.he@corigine.com> <20241011032412.3672788-3-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/10/2024 05:24, Chaoyong He: > From: Long Wu > > The testpmd application can not modify the value of > dedicated hardware Rx/Tx queue size, and hardcoded > them as (128/512). This will cause the bonding port > start fail if some NIC requires more Rx/Tx descriptors > than the hardcoded number. > > Therefore, add a command into testpmd application to > support the modification of the size of the dedicated > hardware Rx/Tx queue. Also export an external interface > to also let other applications can change it. > > Signed-off-by: Long Wu > Reviewed-by: Peng Zhang > Reviewed-by: Chaoyong He There is a lack of review in general for bonding patches. Please could you review this one: https://patches.dpdk.org/project/dpdk/patch/20241015082049.3910138-1-vignesh.purushotham.srinivas@ericsson.com/ Maybe he will do the same for you.