From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 86EAE7D05 for ; Wed, 17 Oct 2018 10:20:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0855721F86; Wed, 17 Oct 2018 04:20:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Oct 2018 04:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=x/6rDUVK2tjkt/6hiW14adDQ+7QIXtShszM1D6pi/SI=; b=aVtVMm3GlYHr WFm/TUdR3i5iakVgdOUxxgnaB4nP7fAitp8jeGQVrMUjII1glpwiaNq0H6UW6Kl/ nBUBFIvP90/ijm210BBP7IcngQfGpjwhh4zPamuIZus1nWpyAtNoPBdl8JVKlEhK 25otEslzM5H+lYCOoBg0UMOJ4eX4J1c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=x/6rDUVK2tjkt/6hiW14adDQ+7QIXtShszM1D6pi/ SI=; b=Y6tDzQZTHSky2X4a8bTe8DF3gDLqo5rre1PMs+3tVsxde3tzAtPk0NAxM Kcm70ydObShMahBZm/mu5tUvUKlmd7DV5ZeVbc/5YBE1Cjsn6Bfsp02w2+PMdYI4 L0JAXWnCtt3EL700BliWB/uBKkl7cc7VkavLGf3IdNturjs+tM2bKfTNdmYYcCId YHhcB6FFJANwwk4R6Fyjg558JXww1ZsDZWD/ffTi0Q7Q+nlxczPWsdmIr4Tn5rIf 2q0NPQG6Hx/byp2l+BqMYmzUcEL4WzSWrXfUgJvpSGzLftKDiDzIlJIj7ER1KOg8 rCMRshGr1MEmjCFwT01JZTZ60a+dA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 05570102D5; Wed, 17 Oct 2018 04:20:45 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: ferruh.yigit@intel.com, dev@dpdk.org, ophirmu@mellanox.com Date: Wed, 17 Oct 2018 10:20:48 +0200 Message-ID: <2356863.vgucDQR85H@xps> In-Reply-To: References: <20180907233929.21950-1-thomas@monjalon.net> <20181017015450.15783-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 08:20:47 -0000 17/10/2018 08:26, Andrew Rybchenko: > On 10/17/18 4:54 AM, Thomas Monjalon wrote: > > The testpmd application aim is for testing; > > so order of operations should not be enforced. > > > > There was a test to forbid detaching before closing a port. > > However, it may interesting to test what happens in such case. > > It is possible for a PMD to automatically close the port when detaching. > > > > Signed-off-by: Thomas Monjalon > > I'm afraid it could be a problem which the patch, since port > close ensures that the port is not used for traffic forwarding. > Right now the check is gone and we can detach port which > is used for traffic forwarding on separate data cores. > So, almost guaranteed crash. Yes I can duplicate this check in detach_port().