DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH v3] eal/windows: ring build on Windows
       [not found] <'20200520093444.14904-1-fady@mellanox.com'>
@ 2020-05-21 14:14 ` Fady Bader
  2020-05-27  8:24 ` [dpdk-dev] [PATCH v4] " Fady Bader
  2020-06-21 12:06 ` [dpdk-dev] [PATCH v5] " Fady Bader
  2 siblings, 0 replies; 5+ messages in thread
From: Fady Bader @ 2020-05-21 14:14 UTC (permalink / raw)
  To: dev
  Cc: thomas, talshn, yohadt, olivier.matz, harini.ramakrishnan,
	ocardona, anand.rawat, ranjit.menon, dmitry.kozliuk

Exported per_lcore__rte_errno function to compile ring for windows.

compilation error logs:
librte_ring_rte_ring.c.obj : error LNK2019: unresolved
external symbol per_lcore__rte_errno referenced in
function rte_ring_lookup

The cause was that per_lcore__rte_errno function wasn't included
in the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.

Signed-off-by: Fady Bader <fady@mellanox.com>
---
Depends-on: series-9374 ("Windows basic memory management")

v3: Fix style issues.

v2: Fix style issues.
---
 lib/librte_eal/rte_eal_exports.def | 1 +
 lib/librte_eal/rte_eal_version.map | 3 +++
 lib/meson.build                    | 6 +++++-
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 854b83bcd..cbb6b8cfe 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -1,5 +1,6 @@
 EXPORTS
 	__rte_panic
+	per_lcore__rte_errno
 	rte_calloc
 	rte_calloc_socket
 	rte_eal_get_configuration
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index bdd014638..0f1b983b8 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -390,4 +390,7 @@ EXPERIMENTAL {
 	rte_trace_point_lookup;
 	rte_trace_regexp;
 	rte_trace_save;
+
+	# added in 20.08
+	__emutls_v.per_lcore__rte_errno;
 };
diff --git a/lib/meson.build b/lib/meson.build
index d190d84ef..30ed9e05e 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -36,7 +36,11 @@ libraries = [
 	'flow_classify', 'bpf', 'graph', 'node']
 
 if is_windows
-	libraries = ['kvargs','eal'] # only supported libraries for windows
+	libraries = [
+		'kvargs',
+		'eal',
+		'ring'
+		] # only supported libraries for windows
 endif
 
 default_cflags = machine_args
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows
       [not found] <'20200520093444.14904-1-fady@mellanox.com'>
  2020-05-21 14:14 ` [dpdk-dev] [PATCH v3] eal/windows: ring build on Windows Fady Bader
@ 2020-05-27  8:24 ` " Fady Bader
  2020-05-27 20:59   ` Ranjit Menon
  2020-06-21 12:06 ` [dpdk-dev] [PATCH v5] " Fady Bader
  2 siblings, 1 reply; 5+ messages in thread
From: Fady Bader @ 2020-05-27  8:24 UTC (permalink / raw)
  To: dev
  Cc: thomas, talshn, yohadt, olivier.matz, harini.ramakrishnan,
	ocardona, anand.rawat, ranjit.menon, dmitry.kozliuk

Exported per_lcore__rte_errno function to compile ring for windows.

compilation error logs:
librte_ring_rte_ring.c.obj : error LNK2019: unresolved
external symbol per_lcore__rte_errno referenced in
function rte_ring_lookup

The cause was that per_lcore__rte_errno function wasn't included
in the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.

Signed-off-by: Fady Bader <fady@mellanox.com>
---
Depends-on: series-9374 ("Windows basic memory management")

v4: rebase on "Windows basic memory management" v5.

v3: Fix style issues.

v2: Fix style issues.
---
 lib/librte_eal/rte_eal_exports.def | 1 +
 lib/librte_eal/rte_eal_version.map | 1 +
 lib/meson.build                    | 6 +++++-
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 854b83bcd..cbb6b8cfe 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -1,5 +1,6 @@
 EXPORTS
 	__rte_panic
+	per_lcore__rte_errno
 	rte_calloc
 	rte_calloc_socket
 	rte_eal_get_configuration
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index dff51b13d..8937bdfea 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -392,4 +392,5 @@ EXPERIMENTAL {
 	rte_mem_lock;
 	rte_mem_map;
 	rte_mem_unmap;
+	__emutls_v.per_lcore__rte_errno;
 };
diff --git a/lib/meson.build b/lib/meson.build
index d190d84ef..30ed9e05e 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -36,7 +36,11 @@ libraries = [
 	'flow_classify', 'bpf', 'graph', 'node']
 
 if is_windows
-	libraries = ['kvargs','eal'] # only supported libraries for windows
+	libraries = [
+		'kvargs',
+		'eal',
+		'ring'
+		] # only supported libraries for windows
 endif
 
 default_cflags = machine_args
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows
  2020-05-27  8:24 ` [dpdk-dev] [PATCH v4] " Fady Bader
@ 2020-05-27 20:59   ` Ranjit Menon
  0 siblings, 0 replies; 5+ messages in thread
From: Ranjit Menon @ 2020-05-27 20:59 UTC (permalink / raw)
  To: Fady Bader, dev
  Cc: thomas, talshn, yohadt, olivier.matz, harini.ramakrishnan,
	ocardona, anand.rawat, dmitry.kozliuk

On 5/27/2020 1:24 AM, Fady Bader wrote:
> Exported per_lcore__rte_errno function to compile ring for windows.
>
> compilation error logs:
> librte_ring_rte_ring.c.obj : error LNK2019: unresolved
> external symbol per_lcore__rte_errno referenced in
> function rte_ring_lookup
>
> The cause was that per_lcore__rte_errno function wasn't included
> in the export list.
> To solve this per_lcore__rte_errno was added to the Windows export
> list.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
> ---
> Depends-on: series-9374 ("Windows basic memory management")
>
> v4: rebase on "Windows basic memory management" v5.
>
> v3: Fix style issues.
>
> v2: Fix style issues.
> ---
>   lib/librte_eal/rte_eal_exports.def | 1 +
>   lib/librte_eal/rte_eal_version.map | 1 +
>   lib/meson.build                    | 6 +++++-
>   3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 854b83bcd..cbb6b8cfe 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -1,5 +1,6 @@
>   EXPORTS
>   	__rte_panic
> +	per_lcore__rte_errno
>   	rte_calloc
>   	rte_calloc_socket
>   	rte_eal_get_configuration
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index dff51b13d..8937bdfea 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -392,4 +392,5 @@ EXPERIMENTAL {
>   	rte_mem_lock;
>   	rte_mem_map;
>   	rte_mem_unmap;
> +	__emutls_v.per_lcore__rte_errno;
>   };
> diff --git a/lib/meson.build b/lib/meson.build
> index d190d84ef..30ed9e05e 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -36,7 +36,11 @@ libraries = [
>   	'flow_classify', 'bpf', 'graph', 'node']
>   
>   if is_windows
> -	libraries = ['kvargs','eal'] # only supported libraries for windows
> +	libraries = [
> +		'kvargs',
> +		'eal',
> +		'ring'
Add a trailing comma here (as in 'ring',). This will ensure that future 
updates don't have to modify this line to add more libraries.
> +		] # only supported libraries for windows
>   endif
>   
>   default_cflags = machine_args


ranjit m.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v5] eal/windows: ring build on Windows
       [not found] <'20200520093444.14904-1-fady@mellanox.com'>
  2020-05-21 14:14 ` [dpdk-dev] [PATCH v3] eal/windows: ring build on Windows Fady Bader
  2020-05-27  8:24 ` [dpdk-dev] [PATCH v4] " Fady Bader
@ 2020-06-21 12:06 ` " Fady Bader
  2020-06-29 23:21   ` Thomas Monjalon
  2 siblings, 1 reply; 5+ messages in thread
From: Fady Bader @ 2020-06-21 12:06 UTC (permalink / raw)
  To: dev
  Cc: thomas, talshn, yohadt, konstantin.ananyev, honnappa.nagarahalli,
	harini.ramakrishnan, ocardona, ranjit.menon, pallavi.kadam,
	dmitry.kozliuk

Building ring on Windows.

Signed-off-by: Fady Bader <fady@mellanox.com>

---

Depends-on: series-10531 ("Windows bus/pci support")

v5: rebase to current master and "Windows bus/pci support" v7.

v4: rebase on "Windows basic memory management" v5.

v3: Fix style issues.

v2: Fix style issues.
---
 lib/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/meson.build b/lib/meson.build
index af66610fcb..9074cb58af 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -38,6 +38,7 @@ libraries = [
 if is_windows
 	libraries = [
 		'kvargs','eal',
+		'ring',
 		'pci',
 	] # only supported libraries for windows
 endif
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v5] eal/windows: ring build on Windows
  2020-06-21 12:06 ` [dpdk-dev] [PATCH v5] " Fady Bader
@ 2020-06-29 23:21   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-06-29 23:21 UTC (permalink / raw)
  To: Fady Bader
  Cc: dev, talshn, yohadt, konstantin.ananyev, honnappa.nagarahalli,
	harini.ramakrishnan, ocardona, ranjit.menon, pallavi.kadam,
	dmitry.kozliuk

21/06/2020 14:06, Fady Bader:
> Building ring on Windows.
> 
> Signed-off-by: Fady Bader <fady@mellanox.com>

Applied with title "ring: enable for Windows"




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <'20200520093444.14904-1-fady@mellanox.com'>
2020-05-21 14:14 ` [dpdk-dev] [PATCH v3] eal/windows: ring build on Windows Fady Bader
2020-05-27  8:24 ` [dpdk-dev] [PATCH v4] " Fady Bader
2020-05-27 20:59   ` Ranjit Menon
2020-06-21 12:06 ` [dpdk-dev] [PATCH v5] " Fady Bader
2020-06-29 23:21   ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox