From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10EC6A00C4; Sun, 10 May 2020 11:52:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6362E1D557; Sun, 10 May 2020 11:52:09 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B51791D51C for ; Sun, 10 May 2020 11:52:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DB50E5C0086; Sun, 10 May 2020 05:52:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 10 May 2020 05:52:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Dzt/fIsGTqOPDh56n0ZNBEfAYX7bmPjKxzVa2xs5EG8=; b=BvTUy08qm9lI8dgh r1Z2EwMW+X9I2bgTiZC81Yyc6x7KPnKjotMmcvbO8ZgtSkqkuflo2Sle/+oSziOL r2cO3ouR1fwjR5KMoqUuthKrs2F6IYp16MLTFj3hx5GdR5wzaOQdW8SqhTGMSrn/ 1PFP7v8W4+avgkUsgrsPJcTRKE1GVREUD+ybfPvmQR4uRugHqsi3Ch6TdOwSFVjC 35Mw39SBzqhXzoFhyQObQecJGnOmZrYrMkyI3dwa8Wf6HWjU4F8FrV6UC032WKaJ 49AjyrEkxCBTvGMP+qjLgGVBjQc+/HEBFsg8WNhMuFSJ3Mf66rCg7VF5sqV6NvWZ iwn7rA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Dzt/fIsGTqOPDh56n0ZNBEfAYX7bmPjKxzVa2xs5E G8=; b=kR78QgTQ9aNVV2GiCh05VqVAO5elMbLxE5SwjyzjnHuM/5dLNI0y8XWvm xsB2n6kOeOE3ymYPA+BkAY5iltT+MmQl+R3qvN3CFDedXdfBmnoJtXl24MUOzW7D /q4IWHjpWuTS14+zCpFXRSRUVn7MTUdZdnuA1a1gTLyjmIaqzRULc4vzawVFdQgN StbTk7A6m28TkyDZkRGcUUof0kcMcHROWDusQkrzl5y9/HtQyKTwn/HiUbx9P913 z+fokf1HCpikeuaeUe9P7W0w7u8X3UYenbkyyEJNLsR7R77gsCGZG/RxT5LRmRsP FUSxyiET6e7+q9Kqi+QJp8tzumJRA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkeekgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1927C3066260; Sun, 10 May 2020 05:52:06 -0400 (EDT) From: Thomas Monjalon To: talshn@mellanox.com, Dmitry Kozlyuk Cc: dev@dpdk.org, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, anatoly.burakov@intel.com Date: Sun, 10 May 2020 11:52:05 +0200 Message-ID: <2362361.TLnPLrj5Ze@thomas> In-Reply-To: <20200508015004.2510c9e7@Sovereign> References: <20200507121646.624-1-talshn@mellanox.com> <20200507121646.624-8-talshn@mellanox.com> <20200508015004.2510c9e7@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 7/7] bus/pci: support Windows with bifurcated drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/05/2020 00:50, Dmitry Kozlyuk: > On 2020-05-07 15:16 GMT+0300 talshn@mellanox.com wrote: > > +static > > +int get_device_pci_address(HDEVINFO hDevInfo, > > + PSP_DEVINFO_DATA pDeviceInfoData, struct rte_pci_addr *addr) > > Result type should be on a separate line (that is, "static int "). > > This is also the first from numerous violations of DPDK naming conventions. > IMO, Windows EAL should strictly follow them to become "a first-class citizen" > in DPDK and to attract existing developers. Even if not, style should be at > least consistent across each file (now we have snake_case, Hungarian > notation, camelCase, and PascalCase mixed). I agree, snake_case must be used for all variables.