[dpdk-dev] [PATCH] eal: check error conditinos for every loop iteration

[dpdk-dev] [PATCH] eal: check error conditinos for every loop iteration

[Neil Horman]

The return code for rte_cpu_get_flag_enabled is only checked on the termination
of the for loop that it is called inside, but should be checked for every
iteration it makes through the for loop.  This is caused by some silly missing
brackets.  Simply add them in

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Pablo De Lara Guarch  <pablo.de.lara.guarch@intel.com>
CC: Pablo De Lara Guarch  <pablo.de.lara.guarch@intel.com>
CC: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 lib/librte_eal/common/eal_common_cpuflags.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_cpuflags.c b/lib/librte_eal/common/eal_common_cpuflags.c
index f9c1840..5c0927c 100644
--- a/lib/librte_eal/common/eal_common_cpuflags.c
+++ b/lib/librte_eal/common/eal_common_cpuflags.c
@@ -255,7 +255,7 @@ rte_cpu_check_supported(void)
 	unsigned i;
 	int ret;
 
-	for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++)
+	for (i = 0; i < sizeof(compile_time_flags)/sizeof(compile_time_flags[0]); i++) {
 		ret = rte_cpu_get_flag_enabled(compile_time_flags[i]);
 
 		if (ret < 0) {
@@ -271,4 +271,5 @@ rte_cpu_check_supported(void)
 			        cpu_feature_table[compile_time_flags[i]].name);
 			exit(1);
 		}
+	}
 }
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] eal: check error conditinos for every loop iteration

[Thomas Monjalon]

2014-04-16 06:50, Neil Horman:
> The return code for rte_cpu_get_flag_enabled is only checked on the
> termination of the for loop that it is called inside, but should be checked
> for every iteration it makes through the for loop.  This is caused by some
> silly missing brackets.  Simply add them in
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> Reported-by: Pablo De Lara Guarch  <pablo.de.lara.guarch@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

It's applied for version 1.6.0r2.
Title is changed: "eal: fix check of all requested CPU features"

Thanks to all for reporting and fixing.
-- 
Thomas