From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63D8AA050B; Thu, 7 Apr 2022 09:42:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1730540689; Thu, 7 Apr 2022 09:42:17 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id C819E4014F for ; Thu, 7 Apr 2022 09:42:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 77C983201487; Thu, 7 Apr 2022 03:42:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 07 Apr 2022 03:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=P/95Od9uuJPz3W JA2HAMDA/PlwpbP+v4undoJKuOVoI=; b=UKpC9+MbMM81jFQsyq9srBUlxXVMwb 6Zsm5rRzrMs5JhoOuydqSik4XeMnSguBQYWoYYzCrYLtLX7Sei9FU2innwY8l5hM LJR2hvO76ssbycuwL0NctOHvkFH9PZggnQw8PBeK4IH3BMXbCZVcbaApMsfeBA8v NikVW6XNs9CAntn78BNn8BzB8jYKKA6Z2aUMYaxow53luNT1nlVQUgVspnHXcPUo O+41nRczb2nVJeTGlR1j338TWiR253axTBRav+y3lMReBZe/hpkJZtPYHUIfngD3 RsoCcjNbgaxOYL5bjJ0k6k4BnhKsS9XlfkUrTtBFSi1tavXWFdLwKlgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=P/95Od9uuJPz3WJA2HAMDA/PlwpbP+v4undoJKuOV oI=; b=f2OHfQDSJlCZhXfFdTJfoosgFLo+4cNn1gAzvzfs0g3npv4thnxcf6Ek1 AfCq57aNjU2kxSI4cv66DAxcaG3VTFBTivgUnFsBFFQkUN4ArPze1jLuRK5XYVhn Nerpuohi6ucRiVxRz6XPxULmroQx6Xy9zo/ya2bv1pU/M6C32xay9L38cVh87ol3 NkwCIaG2iYcFNiAlNpxXDPimstvz94Prq+zkXTTLY4nQ6k+EmKxYerIAPpK7JlWX Fy7BqWhTnRfnBCFBBqMz0Y0cX2are6ox0zfcsTtuJ+qJlW4A5BZ5OJJX8TnW7hg1 RUCZfCd1RJ3lpAWnNXGCvSpSCmWMw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 03:42:12 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: Stephen Hemminger , dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH] kni: fix device address set Date: Thu, 07 Apr 2022 09:42:11 +0200 Message-ID: <2364580.jE0xQCEvom@thomas> In-Reply-To: <40f8ce34-982c-d96f-b1a7-d8381c36dcf1@huawei.com> References: <20220406082213.45750-1-humin29@huawei.com> <20220406081700.4aa2d9a7@hermes.local> <40f8ce34-982c-d96f-b1a7-d8381c36dcf1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/04/2022 02:44, Min Hu (Connor): > Hi, Stephen, > I think this is a good option, but the macro definition is like: > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 14, 0) > +#define ether_addr_copy(dst, src) memcpy(dst, src, ETH_ALEN) > +#endif > > @Ferry, why is it limited for "LINUX_VERSION_CODE < KERNEL_VERSION(3, > 14, 0)" ? I guess that's because it is defined in "new kernels" so we need a definition in DPDK for old kernels.