DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: replace single bit masks with macros
Date: Fri, 22 Oct 2021 09:24:51 +0200	[thread overview]
Message-ID: <2364635.PxhEfK7eOE@thomas> (raw)
In-Reply-To: <20211022072313.390612-1-andrew.rybchenko@oktetlabs.ru>

22/10/2021 09:23, Andrew Rybchenko:
>  /** PMD supports thread-safe flow operations */
> -#define RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE  0x0001
> +#define RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE  RTE_BIT32(0)
>  /** Device supports link state interrupt */
> -#define RTE_ETH_DEV_INTR_LSC     0x0002
> +#define RTE_ETH_DEV_INTR_LSC              RTE_BIT32(1)
>  /** Device is a bonded slave */
> -#define RTE_ETH_DEV_BONDED_SLAVE 0x0004
> +#define RTE_ETH_DEV_BONDED_SLAVE          RTE_BIT32(2)
>  /** Device supports device removal interrupt */
> -#define RTE_ETH_DEV_INTR_RMV     0x0008
> +#define RTE_ETH_DEV_INTR_RMV              RTE_BIT32(3)
>  /** Device is port representor */
> -#define RTE_ETH_DEV_REPRESENTOR  0x0010
> +#define RTE_ETH_DEV_REPRESENTOR		  RTE_BIT32(4)

misalignment here

>  /** Device does not support MAC change after started */
> -#define RTE_ETH_DEV_NOLIVE_MAC_ADDR  0x0020
> +#define RTE_ETH_DEV_NOLIVE_MAC_ADDR       RTE_BIT32(5)





  reply	other threads:[~2021-10-22  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22  7:23 Andrew Rybchenko
2021-10-22  7:24 ` Thomas Monjalon [this message]
2021-10-22  7:30 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-10-22 16:40   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2364635.PxhEfK7eOE@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).