From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDC53A0487 for ; Thu, 4 Jul 2019 15:21:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B47BA1BE39; Thu, 4 Jul 2019 15:21:00 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0ACB41BE36 for ; Thu, 4 Jul 2019 15:20:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 70B3B21F14; Thu, 4 Jul 2019 09:20:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 09:20:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/SmbFcCjv16COfhfH1DRr8v6wIExBZ/cXulUwEYD5E4=; b=gPLedfku6+D1 CYihlVFBg3GdNrLk/YKvll7rsXE/J3zr4pGrvPkgYpmwGu/qqSXmfG8PH8+AaLTW xaJ2QA3/cJ05t/a9cxPe4K8FXYiU+INCYHi+Phf7q9QCeQrmLesYjlCTWdHvmmzV SyhXT2C+7gvbDtvBCuRqxP5GM6bMlho= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/SmbFcCjv16COfhfH1DRr8v6wIExBZ/cXulUwEYD5 E4=; b=oH212AawrZdagBUNJVaN4lH4fil8M/Yai33huWDIqPXLRigJ5SgBHmf7P 5h+m6Wdz43MLu6yUu2n9kkDsgPlfTlWHzufhsUOywRNgMrDm5bionR3P75bItsZS SG5+S13M5ISwL2BJvD0g4tQm4xkEZNnuvpQbdlxXBiRVEPYRpE6ucyPegovSwhJ4 XF8UGaGhAJmYeBBVB/xNzVoryUW2cTSw4XKffYd6XnR02AhAETXhG97NDGZ8lcYT aFNZ9I/AyWrXdZOUyvtaS2vLnmtFOk+lSvYGcK3JF5BHaH6x+eFy6LSRaoloLDVS kqM0XGynDbMAFd18NTK9u1e1TrFgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 698298005C; Thu, 4 Jul 2019 09:20:57 -0400 (EDT) From: Thomas Monjalon To: Natanael Copa Cc: dev@dpdk.org Date: Thu, 04 Jul 2019 15:20:55 +0200 Message-ID: <2364933.uslMzlRZWI@xps> In-Reply-To: <20190704141639.2334b40d@ncopa-desktop.copa.dup.pw> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <5813741.aTzT6Pizmj@xps> <20190704141639.2334b40d@ncopa-desktop.copa.dup.pw> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/07/2019 14:16, Natanael Copa: > On Sat, 30 Mar 2019 23:22:27 +0100 > Thomas Monjalon wrote: > > > 13/03/2019 18:06, Natanael Copa: > > > Add a fallback for non-GNU libc systems like musl libc for the > > > non-standard functions outl_p, outw_p and outb_p. > > > > > > This ifixes the following buildtime errors when building with musl libc: > > > pci_uio.c:(.text+0xaa1): undefined reference to `outw_p' > > > pci_uio.c:(.text+0xac5): undefined reference to `outl_p' > > > pci_uio.c:(.text+0xadf): undefined reference to `outb_p' > > > > > > fixes https://bugs.dpdk.org/show_bug.cgi?id=35 > > > > Please use this syntax: > > Bugzilla ID: 35 > > Ok. > > > > > [...] > > > #if defined(RTE_ARCH_X86) > > > #include > > > +#if defined(__GLIBC__) > > > +#define pci_uio_outl_p outl_p > > > +#define pci_uio_outw_p outw_p > > > +#define pci_uio_outb_p outb_p > > > +#else > > > +static inline void > > > +pci_uio_outl_p(unsigned int value, unsigned short int port) > > > +{ > > > + __asm__ __volatile__ ("outl %0,%w1\noutb %%al,$0x80" : : "a" (value), > > > + "Nd" (port)); > > > +} > > > + > > > +static inline void > > > +pci_uio_outw_p(unsigned short int value, unsigned short int port) > > > +{ > > > + __asm__ __volatile__ ("outw %w0,%w1\noutb %%al,$0x80" : : "a" (value), > > > + "Nd" (port)); > > > +} > > > + > > > +static inline void > > > +pci_uio_outb_p(unsigned char value, unsigned short int port) > > > +{ > > > + __asm__ __volatile__ ("outb %b0,%w1\noutb %%al,$0x80" : : "a" (value), > > > + "Nd" (port)); > > > +} > > > +#endif > > > #endif > > [...] > > > #if defined(RTE_ARCH_X86) > > > - outl_p(*(const uint32_t *)s, reg); > > > + pci_uio_outl_p(*(const uint32_t *)s, reg); > > > #else > > > *(volatile uint32_t *)reg = *(const uint32_t *)s; > > > #endif > > > > Could we manage non-x86 case in the macros pci_uio_out? > > I did that in separate commit. Do you want do both in same commit? Maybe change the order of commits? Anyway I think you need to rebase and resend this series :)