From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 8981E1B2B7
 for <dev@dpdk.org>; Mon,  6 Nov 2017 22:07:32 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1CF8720840;
 Mon,  6 Nov 2017 16:07:32 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Mon, 06 Nov 2017 16:07:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=B5EftI6QZjdkjsmQ74We5R6ZHG
 mhGHAjV+Eig8LhmN0=; b=F5PcUPkuLq87AKtD6kF25W8cwGBM/UCP5bbv9DLFdK
 pdPO0UazBeB4L9a8kTJMZGSEPCsTwFsrfDU0oJCS6tniySeWE+wRxuqGVMqiDYPX
 ayHUHSZ1OYHCdojvoCckz1jWIXUmjsZrJtVSsbwSmcoefRRtVd5uFK5A8NkMUeJe
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=B5EftI
 6QZjdkjsmQ74We5R6ZHGmhGHAjV+Eig8LhmN0=; b=m04e8sCd3/ITYGjKcFx8GT
 /+ZB0V19DEaSHaxAkUmGazy2o8Akl7yew4Vy3A/jGWSEuo7bt8A7LKvOAxaCvgc1
 8dkAlZF8oFYIHxy0Mjh1hAbrR9eLkO1r7mJkgc/j7neYuM3CScV5O9VUKy4aerGS
 eZb4UErtAXK6Ag7A8YSn/GSoipRDhI6+0tvyv0S0xXi3e1IsAj54ztJgWHRApD5g
 6k2ajnvedG6I8Kt7luaUDptBan8RZQ2vhTx8HKCEsTxO20JGKerNGK8w1Krlu14h
 D9zIdF/KwKjtEZBjc3F8EJB1y8TmW4nwCuk3ylWKnC05Y9thgS4mqE8QpdwKvRlA
 ==
X-ME-Sender: <xms:FM8AWkJiCei10wnVHqi8WF_SIGLHYcnkOAP7lLKXW3Hxl62YStpflw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C6F017E6B8;
 Mon,  6 Nov 2017 16:07:31 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>,
 Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Date: Mon, 06 Nov 2017 22:07:30 +0100
Message-ID: <2369574.SFH6e9u1pT@xps>
In-Reply-To: <1509702003-70630-1-git-send-email-david.hunt@intel.com>
References: <1509702003-70630-1-git-send-email-david.hunt@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Nov 2017 21:07:32 -0000

03/11/2017 10:40, David Hunt:
> From: Vipin Varghese <vipin.varghese@intel.com>
> 
> with 'export TOOLCHAIN_CFLAGS' the values are
> not inherited throuhout make system. The change
> appends the user defined cflags.

Why do you want to use export from the shell environment?
The standard way of overriding a variable with make,
is to specify a value on the make command line.

[...]
> -TOOLCHAIN_ASFLAGS =
> -TOOLCHAIN_CFLAGS =
> -TOOLCHAIN_LDFLAGS =
> +TOOLCHAIN_ASFLAGS +=
> +TOOLCHAIN_CFLAGS +=
> +TOOLCHAIN_LDFLAGS +=

There is nothing to append here.
It is here only for documentation purpose.
If you really want to take environment value into account,
you can just comment this assignment or use ?= operator.

Note that you can also use EXTRA_CFLAGS.
I would be in favor of removing these variables.
We have too many variables.