From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BFA2D1B784; Wed, 31 Jan 2018 18:20:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5897220BB1; Wed, 31 Jan 2018 12:20:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 31 Jan 2018 12:20:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=c6ISluQm+E4PxpcZ91EZ6RPR9n A6ZHexI8LYF7GvOFY=; b=ap/X1VSMi2njK9w2iZ5c8G/IJowby5HtMwBCUBXi1w tR7xBo7u+5zBlxW4ChMSzZJHpYIEITLRffOGK6LNYDYiBwPl3evzxnfnSUFJMQOC T9BE6vCnrvM621S25qkpVotH94raB6V6njlPm0Ni8+RewbQG1z1LmXnxVaZ6u+te 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=c6ISlu Qm+E4PxpcZ91EZ6RPR9nA6ZHexI8LYF7GvOFY=; b=PX3CDGAG1hxTFBKfytBw77 Zo0bquYyNuX0tikiSg4KHQvUFjBc1o5soYyu1KDISdh6QSwjtop8qjgfSSx+FKgP c9UY1SxOlxks15zUzkme0MMcppgF8tGjl6g51wsSQ6Q+tcrxj0kMPPrkmDeeNzPh 4F6oCJZJ4BhTyviDbazKp0ojZxIv1FeBnYWj/nY5x+u8Xv32XHpG7AQrBF8HsvjV sWNI6k6tvll3zxrHUw9xGJiW2fSsCoCGeqdB3MyiL+CXIdjEd8tafOLf6yjGJ4a6 Ok+NFuPoX5spjmp/7AmxR0eZqPS5h58D9Cvm2NFMAHdS7QSyskxJ8j/PSyVRk5ww == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB869247A9; Wed, 31 Jan 2018 12:20:11 -0500 (EST) From: Thomas Monjalon To: Moti Haimovsky Cc: wenzhuo.lu@intel.com, dev@dpdk.org, techboard@dpdk.org Date: Wed, 31 Jan 2018 18:19:25 +0100 Message-ID: <2371406.ix6cSJql9R@xps> In-Reply-To: <1517417958-30594-1-git-send-email-motih@mellanox.com> References: <1517399745-21303-1-git-send-email-motih@mellanox.com> <1517417958-30594-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx offloads by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 17:20:12 -0000 31/01/2018 17:59, Moti Haimovsky: > Removed the hardcoded preconfigured Rx and Tx offload configuration > from testpmd and changed the Rx offload command line parameters from > disable to enable. The description must be updated because v6 does not remove the last default Tx offload. > Testers who wish to use these offloads will now have to explicitly > write them in the command-line when running testpmd. > The above does not apply to Rx crc-strip and Tx MBUF_FAST_FREE which > were not removed and are silently dropped in ports that do not > support them. Can be added here: It has been decided by the Technical Board. > Motivation: > Some PMDs such at the mlx4 may not implement all the offloads. > After the offload API rework assuming no offload is enabled by default, > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying > to enable a not supported offload is clearly an error which will cause > configuration failing. > > Considering that testpmd is an application to test the PMD, it should > not fail on a configuration which was not explicitly requested. > The behavior of this test application is then turned to an opt-in > model. > > Signed-off-by: Moti Haimovsky > --- > V6: > Returned DEV_RX_OFFLOAD_CRC_STRIP and DEV_TX_OFFLOAD_MBUF_FAST_FREE > as default config values. Thank you, it reflects what has been decided today in the Technical Board meeting. We discussed the need of not having offloads by default in testpmd. There are only two exceptions for 18.02: - Rx CRC strip is often required, and the flag could be completely removed or reversed in 18.05. - Tx fast free could be discussed more.