From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ED3CD1B74D
 for <dev@dpdk.org>; Tue, 15 May 2018 17:38:03 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 57CC222337;
 Tue, 15 May 2018 11:38:03 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 15 May 2018 11:38:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=QYT3EDB4oBDCk7FxSm3RZHSXGQ
 diQH3TVYqJ12CJOXk=; b=eoXJVGCXd9CL+NScY+uUoIbaKEhGMXvMBiS4I4le0j
 QRapKik7HUvtWotk9pTDOHLl7KI+THxWrVl5bLED0wXv+lrIFlo2Nhuua510nRG8
 9sxaE7rPBdY6mrCr4cXbiZzG7/T0Zy9bTFsth5wu2btY3w/C4TJ7S2Wx8GixQhXx
 o=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QYT3ED
 B4oBDCk7FxSm3RZHSXGQdiQH3TVYqJ12CJOXk=; b=Mu9r6azF6gcQ2sGvLrolAV
 k04xUHd/kdJBGnazZXD2jP3w8Qf5ckrrDfV58pVswhLsUZNbH3woI78PXKRN54h1
 S2eEVw551ryIMlvME57ZgnRlU9c4VhDUSWFK97h3yAiJIl/+34QDC/6o0lDquKcO
 5GRbaNWncCWzcqBejxKOOE0gEaCA2A/hewqpEOHK1FqorGFgoepQVW34SLOh66AO
 SD0gtpOCwb2v7xEXJx4+QzFtzDaoHUNxqJFiULsqQJuQFdUrjo6e99hO0ApEIzAz
 4AadUD2a75TYt5gnLvc04/3/OXA3FBi4s8AJrfWfwAe7jflSzzDZUzoR+ILAri3Q
 ==
X-ME-Sender: <xms:2_76WhA-2EbyW7Zh2H8oUK86Ee3GN1mbFBwFb296ihCgy9UlObeGPQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B35F2E4854;
 Tue, 15 May 2018 11:38:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, vipin.varghese@intel.com
Date: Tue, 15 May 2018 17:38:01 +0200
Message-ID: <2371860.oF3rqsruhg@xps>
In-Reply-To: <1526395965-133647-1-git-send-email-harry.van.haaren@intel.com>
References: <1526395965-133647-1-git-send-email-harry.van.haaren@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal/service: improve error checking of
	coremasks
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 May 2018 15:38:04 -0000

15/05/2018 16:52, Harry van Haaren:
> +	if (eal_service_cores_parsed())
> +		RTE_LOG(ERR, EAL,
> +			"Warning: Service cores parsed before dataplane cores. Ensure -c is before -s or -S.\n");
> +
[...]
> +	if (core_parsed && taken_lcore_count != count) {
> +		RTE_LOG(ERR, EAL,
> +			"Warning: not all service cores were in the coremask - ensure -c or -l includes service cores\n");
> +	}

Sometimes, messages are split with a dot, sometimes with a dash.
Please choose only one for consistency (I prefer dot).
I think you can split the string and wrap the line at the end of the sentence.