From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 665348E9E for ; Wed, 4 Nov 2015 17:58:30 +0100 (CET) Received: by wmeg8 with SMTP id g8so115853592wme.0 for ; Wed, 04 Nov 2015 08:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=WLj91vIb+EIJoPn4mBqXfuQ0dsk5Eaq8/BOgwiOlRfs=; b=uIIOxc/iKY+Q4yuZH3aBbL6wOYcezwwl2nxegkK7DL2KbXs/LGs+5vIp+ZwMOYO7YQ DnXdghjjPkqt3+c7tS3lWRVNo1t4rtsGBrP5XFYvySLi57IEnCz6KXzYcWv+xkbPjGm8 SWDSYEMiNrjmhwOIRwT8HbPaUcZbqi1UCxChQxKaW9quWqa85WtUEko/Ml5xXRnyK2eg +46+A2go8GmxBs43ACpKWIIRltS99PJyzcvi6raU/hnxJDP2XhPyHY4PjC70KuXM61Lo 5R4pgp05FOF49CuJKHuSZKmHc00fKGcPR59YZTYwZa88iJLxTcZG0wPU4SdN9FsDSSjQ G3zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=WLj91vIb+EIJoPn4mBqXfuQ0dsk5Eaq8/BOgwiOlRfs=; b=EURS4fSyyzM2v+kQSLPzxeCQX0TSSBweG7+bSMt0ZwuzjX7HSsn1DLp1IYA5Adm4Z2 o9OmZcPebGdD98w8MXq5weON+0Y0vaUkgPPI4io77h7RDLBE/OyeeKuNvd3BeK/DcICW Mqu3fRDjM8769/5Jw8oDOXzQo/hUs/QeiL8+qMNcz5V6QoYYz7iNvRFJ9DpVdfEUzU/P rFEa5mifo0/xTqW4I8wmII+4WmMURJRIJAPqRty5izyJIunnrBErE8VkcZ3TdRGnthEP RxnMR1IRKMzXbAlvFERrEkiZfxR2NQZXTIJA+97YOlpOCfl6XwuXkUJVgzdbZtPZKXJx niaA== X-Gm-Message-State: ALoCoQl7O1PObLrKqBHmdYhfpihMP1jrJtFzIwdydzEJ5cBQ3Pl60rNYoQ7mzltRODmIrJO3as6P X-Received: by 10.28.134.205 with SMTP id i196mr25417960wmd.17.1446656310267; Wed, 04 Nov 2015 08:58:30 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id m137sm29652710wmb.2.2015.11.04.08.58.29 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Nov 2015 08:58:29 -0800 (PST) From: Thomas Monjalon To: Harry van Haaren Date: Wed, 04 Nov 2015 17:57:17 +0100 Message-ID: <23734920.erH16WLlfy@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446653683-10407-1-git-send-email-harry.van.haaren@intel.com> References: <5639CB88.7040108@allegro-packets.com> <1446653683-10407-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: remove l3_l4_xsum_errors from rx errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 16:58:30 -0000 2015-11-04 16:14, Harry van Haaren: > This patch removes l3_l4_xsum_errors from rx errors. > > The reason to remove it is that UDP packets have an optional checksum, and > when not calculated the checksum field should be set to zero. When the > checksum is not calculated (zero-ed out), the hardware still counts a valid > UDP packet as an l3_l4_xsum_error. > > This hardware issue is documented in 82599 errata, titled: > "Integrity Error Reported for IPv4/UDP Packets with Zero Checksum" > > The solution is to remove l3_l4_xsum_errors from rx_errors, as discussed on > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/25590/ > > Fixes: f6bf669b9900 ("ixgbe: account more Rx errors") > > Suggested-by: Martin Weiser > Signed-off-by: Harry van Haaren Applied, thanks