From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04532A04DD; Wed, 28 Oct 2020 15:22:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A3EECB04; Wed, 28 Oct 2020 15:22:06 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 4C5F7CACD for ; Wed, 28 Oct 2020 15:22:05 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 68761580155; Wed, 28 Oct 2020 10:22:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 28 Oct 2020 10:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= IQitnGCcPmOVHW/68PpK4FPyyllQsSnw+SMnzWuHWgE=; b=EF1tOnb2df0idpYQ Y+eET/4BWz/q6VrNKBIKVX//CYpfAGYA3lZsPQER0IdxMa30V7nkox50K5CkMPGI Go1R0iPRQWuRJYxSXdqI/k+6WSYW41utBQ0Usm1DqfFYLCp4ESypOANn87+jP0Bn WdMNN52t22AK3qZEhOWlTQa9FTfACcXI4a/pyiz6YN7nNeITZZc4Ld6unPpXdQkx GbBWphcWPRXhpe5DLsGTWWkj95Lo147/4fOrG/DBqQ2Bouxbv6EA+Qk3zz/d2Gof yOUwb/8nk09/4OtQ5nMB/HUpWGW+DE19J6mBMTm3w9Sv1M/vlbRgLKR7Nt2qYMk9 KY7nXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=IQitnGCcPmOVHW/68PpK4FPyyllQsSnw+SMnzWuHW gE=; b=b2dIhwRkJvNAyLnXC9WNLTLr5/3phooVjiSKx+gO7Xd9JLmTadc1hsgEL z3v6PFSfYOBruII6sVfZzvifTv4cvvmJG9YypQdM4ceWoTEtdfcZU+2szEGBbqg3 Gv1qPcZbIAcMgYsvk60eKhCwTD9PbVryz/sSuuNx5Ia3EwS18qqxOidBl8kDkUq5 4Yqj0790Qwo9E/jVTKT+UjBX/7D8FNxuvpyPiWmeoR32JoN9D5tFDFYgUbkd7lHr Bb/cC18G2CYAOZhCwOZ4QagYSR7Ko7Qas0XGoSr7soRKhfflS9OavsUwwmWIAkTk BbyjxSaJNm3AXRTOSpVgI7dUC6uaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 789E43280059; Wed, 28 Oct 2020 10:21:59 -0400 (EDT) From: Thomas Monjalon To: "Liang, Ma" , Jerin Jacob Cc: dpdk-dev , "Ruifeng Wang (Arm Technology China)" , Haiyue Wang , "Richardson, Bruce" , "Ananyev, Konstantin" , David Hunt , Neil Horman , "McDaniel, Timothy" , Gage Eads , Marcin Wojtas , Guy Tzalik , Ajit Khaparde , Harman Kalra , John Daley , "Wei Hu (Xavier" , Ziyang Xuan , matan@nvidia.com, Yong Wang , david.marchand@redhat.com Date: Wed, 28 Oct 2020 15:21:58 +0100 Message-ID: <2373759.1G5EZAqFcn@thomas> In-Reply-To: References: <1603494392-7181-1-git-send-email-liang.j.ma@intel.com> <20201028133507.GC29706@sivswdev09.ir.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2020 14:49, Jerin Jacob: > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > Hi Thomas, > > I think I addressed all of the questions in relation to V9. I don't think I can solve the issue of a generic API on my own. From the Community Call last week Jerin also said that a generic was investigated but that a single solution wasn't feasible. > > I think, From the architecture point of view, the specific > functionally of UMONITOR may not be abstracted. > But from the ethdev callback point of view, Can it be abstracted in > such a way that packet notification available through > checking interrupt status register or ring descriptor location, etc by > the driver. Use that callback as a notification mechanism rather > than defining a memory-based scheme that UMONITOR expects? or similar > thoughts on abstraction. I agree with Jerin. The ethdev API is the blocking problem. First problem: it is not well explained in doxygen. Second problem: it is probably not generic enough (if we understand it well) > > This API is experimental and other vendor support can be added as needed. If there are any other open issue let me know? Being experimental is not an excuse to throw something which is not satisfying.