From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: john.mcnamara@intel.com, ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note
Date: Mon, 25 May 2020 00:47:00 +0200 [thread overview]
Message-ID: <2374873.m242xcD6Ei@thomas> (raw)
In-Reply-To: <20190311183939.21166-1-ktraynor@redhat.com>
11/03/2019 19:39, Kevin Traynor:
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> - Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
> + Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
tab Vs spaces :D
I am not sure what is the most followed convention in DPDK.
I thought most of alignments were done with spaces only.
I mean spaces before an end-of-line comment:
struct foo {
int an_interesting_field; /* mandatory */
char poor_field; /* optional thing */
}
next prev parent reply other threads:[~2020-05-24 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 18:39 Kevin Traynor
2019-03-11 23:08 ` Rami Rosen
2019-03-25 11:36 ` Kovacevic, Marko
2019-03-25 11:36 ` Kovacevic, Marko
2020-05-24 22:47 ` Thomas Monjalon [this message]
2020-05-25 9:54 ` Mcnamara, John
2023-06-12 15:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2374873.m242xcD6Ei@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).