From: Thomas Monjalon <thomas@monjalon.net>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal: fix resource leak
Date: Wed, 11 Oct 2017 14:43:39 +0200 [thread overview]
Message-ID: <2376015.Aqjpq7JAko@xps> (raw)
In-Reply-To: <20171011115353.40043-1-danielx.t.mrzyglod@intel.com>
11/10/2017 13:53, Daniel Mrzyglod:
> Memory allocated in strdup is not free.
>
> Coverity issue: 143257
> Fixes: d8a2bc71dfc2 ("log: remove app path from syslog id")
> Cc: thomas@monjalon.net
> Cc: stable@dpdk.org
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Given this recent commit:
http://dpdk.org/commit/e3f141879ef
I think we should consider this issue as a false positive.
The arguments given to rte_eal_init may be freed.
So it's better to strdup them, even if it is never freed.
prev parent reply other threads:[~2017-10-11 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 13:34 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2017-09-22 14:48 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2017-10-02 14:16 ` Jastrzebski, MichalX K
2017-10-04 19:24 ` Ferruh Yigit
2017-10-05 22:33 ` Thomas Monjalon
2017-10-11 11:53 ` [dpdk-dev] [PATCH v3] " Daniel Mrzyglod
2017-10-11 12:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2376015.Aqjpq7JAko@xps \
--to=thomas@monjalon.net \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).